From 5df0b1e5cf4a55e7ff23415d7563ed297223ddbf Mon Sep 17 00:00:00 2001 From: Brian Neradt Date: Wed, 19 Nov 2025 21:54:24 +0000 Subject: [PATCH] Clean up certifier SslData destructor Remove the commented-out debug statement from the SslData destructor. This statement was commented out in PR #9792 as a stop-gap measure because it was causing crashes during shutdown when accessing the potentially-destroyed dbg_ctl static object. Let's close the associated issue by just removing the commented out debug statement since it is generally considered unsafe to log in a destructor precisely because of its use of static structures which can surface order-dependent issues like the one reported in #9794. That is, not logging in the destructor is the correct solution, so let's just make @maskit's patch official. Fixes: #9794 --- plugins/certifier/certifier.cc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/plugins/certifier/certifier.cc b/plugins/certifier/certifier.cc index e621a1a6be9..6dd3ec82259 100644 --- a/plugins/certifier/certifier.cc +++ b/plugins/certifier/certifier.cc @@ -106,8 +106,8 @@ class SslLRUList SslData *prev = nullptr; SslData *next = nullptr; - SslData() = default; - ~SslData() { /* Dbg(dbg_ctl, "Deleting ssl data for [%s]", commonName.c_str()); */ } + SslData() = default; + ~SslData() = default; }; using scoped_SslData = std::unique_ptr;