From c04191254370a96eae6f75ea744af33bd14bd851 Mon Sep 17 00:00:00 2001 From: Masakazu Kitajo Date: Thu, 20 Aug 2020 14:57:49 +0900 Subject: [PATCH] Comment out a wrong assertion in QUIC Loss Detection logic The assertion is on the spec, but not correct. It will be fixed on the next draft. --- iocore/net/quic/QUICLossDetector.cc | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/iocore/net/quic/QUICLossDetector.cc b/iocore/net/quic/QUICLossDetector.cc index a52ec684d42..702f17ac75d 100644 --- a/iocore/net/quic/QUICLossDetector.cc +++ b/iocore/net/quic/QUICLossDetector.cc @@ -447,7 +447,10 @@ QUICLossDetector::_on_loss_detection_timeout() this->_get_pto_time_and_space(pns); this->_send_one_or_two_ack_eliciting_packet(pns); } else { - ink_assert(this->_is_client_without_one_rtt_key()); + // This assertion is on draft-29 but not correct + // Keep it as a comment for now to not add it back + // ink_assert(this->_is_client_without_one_rtt_key()); + // Client sends an anti-deadlock packet: Initial is padded // to earn more anti-amplification credit, // a Handshake packet proves address ownership.