From a13dc03f7d78a17a305bf049cf462fe643a47693 Mon Sep 17 00:00:00 2001 From: bneradt Date: Tue, 27 Apr 2021 22:29:50 +0000 Subject: [PATCH] AuTest extension: check for unrecognized configurations This adds a trafficserver AuTest extension check to verify that the AuTests do not accidentally add an unrecognized configuration option. It also removes the use of deprecated or otherwise unneeded configurations that it found. --- tests/gold_tests/autest-site/trafficserver.test.ext | 3 +++ tests/gold_tests/basic/deny0.test.py | 1 - tests/gold_tests/chunked_encoding/chunked_encoding_h2.test.py | 1 - tests/gold_tests/slow_post/slow_post.test.py | 2 -- tests/gold_tests/timeout/conn_timeout.test.py | 1 - tests/gold_tests/timeout/tls_conn_timeout.test.py | 1 - 6 files changed, 3 insertions(+), 6 deletions(-) diff --git a/tests/gold_tests/autest-site/trafficserver.test.ext b/tests/gold_tests/autest-site/trafficserver.test.ext index ea9412eebd1..c679dc2db8b 100755 --- a/tests/gold_tests/autest-site/trafficserver.test.ext +++ b/tests/gold_tests/autest-site/trafficserver.test.ext @@ -187,6 +187,9 @@ def MakeATSProcess(obj, name, command='traffic_server', select_ports=True, "ERROR:", "diags.log should not contain errors") p.Disk.diags_log.Content += Testers.ExcludesExpression( "FATAL:", "diags.log should not contain errors") + p.Disk.diags_log.Content += Testers.ExcludesExpression( + "Unrecognized configuration value", + "diags.log should not contain a warning about an unrecognized configuration") if command == "traffic_manager": fname = "manager.log" diff --git a/tests/gold_tests/basic/deny0.test.py b/tests/gold_tests/basic/deny0.test.py index 17450a194fb..285ad4c0773 100644 --- a/tests/gold_tests/basic/deny0.test.py +++ b/tests/gold_tests/basic/deny0.test.py @@ -35,7 +35,6 @@ ts.Disk.records_config.update({ 'proxy.config.diags.debug.enabled': 1, 'proxy.config.diags.debug.tags': 'http|dns|redirect', - 'proxy.config.http.redirection_enabled': 1, 'proxy.config.http.number_of_redirections': 1, 'proxy.config.dns.nameservers': '127.0.0.1:{0}'.format(dns.Variables.Port), 'proxy.config.dns.resolv_conf': 'NULL', diff --git a/tests/gold_tests/chunked_encoding/chunked_encoding_h2.test.py b/tests/gold_tests/chunked_encoding/chunked_encoding_h2.test.py index 964e6d7e77f..dee109d1e23 100644 --- a/tests/gold_tests/chunked_encoding/chunked_encoding_h2.test.py +++ b/tests/gold_tests/chunked_encoding/chunked_encoding_h2.test.py @@ -35,7 +35,6 @@ ts.addDefaultSSLFiles() ts.Disk.records_config.update({ - 'proxy.config.http2.enabled': 1, # this option is for VZM-internal only 'proxy.config.diags.debug.enabled': 0, 'proxy.config.diags.debug.tags': 'http', 'proxy.config.ssl.server.cert.path': '{0}'.format(ts.Variables.SSLDir), diff --git a/tests/gold_tests/slow_post/slow_post.test.py b/tests/gold_tests/slow_post/slow_post.test.py index 2d508165c63..35bcbec644d 100644 --- a/tests/gold_tests/slow_post/slow_post.test.py +++ b/tests/gold_tests/slow_post/slow_post.test.py @@ -56,8 +56,6 @@ def setupTS(self): 'proxy.config.diags.debug.enabled': 1, 'proxy.config.diags.debug.tags': 'http', 'proxy.config.http.per_server.connection.max': self._origin_max_connections, - # Disable queueing when connection reaches limit - 'proxy.config.http.per_server.connection.queue_size': 0, }) def run(self): diff --git a/tests/gold_tests/timeout/conn_timeout.test.py b/tests/gold_tests/timeout/conn_timeout.test.py index 7238c4253c5..7eb34cf714b 100644 --- a/tests/gold_tests/timeout/conn_timeout.test.py +++ b/tests/gold_tests/timeout/conn_timeout.test.py @@ -33,7 +33,6 @@ ts.Disk.records_config.update({ 'proxy.config.url_remap.remap_required': 1, 'proxy.config.http.connect_attempts_timeout': 2, - 'proxy.config.http.post_connect_attempts_timeout': 2, 'proxy.config.http.connect_attempts_max_retries': 0, 'proxy.config.http.transaction_no_activity_timeout_out': 5, 'proxy.config.diags.debug.enabled': 0, diff --git a/tests/gold_tests/timeout/tls_conn_timeout.test.py b/tests/gold_tests/timeout/tls_conn_timeout.test.py index 419ec13d034..8493243cdec 100644 --- a/tests/gold_tests/timeout/tls_conn_timeout.test.py +++ b/tests/gold_tests/timeout/tls_conn_timeout.test.py @@ -43,7 +43,6 @@ ts.Disk.records_config.update({ 'proxy.config.url_remap.remap_required': 1, 'proxy.config.http.connect_attempts_timeout': 1, - 'proxy.config.http.post_connect_attempts_timeout': 1, 'proxy.config.http.connect_attempts_max_retries': 1, 'proxy.config.http.transaction_no_activity_timeout_out': 4, 'proxy.config.diags.debug.enabled': 0,