From 5ae31fe655ad919edb18ff22d608b88223445be4 Mon Sep 17 00:00:00 2001
From: Randall Meyer <rrm@apache.org>
Date: Fri, 24 Jun 2022 11:55:20 -0700
Subject: [PATCH] Allows errors from plugin initialization to bubble up

Prior to this change, if plugin initialization fails, the error message from plugin init
would get cleared when trying to unload the DSO.
---
 proxy/http/remap/PluginDso.cc | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/proxy/http/remap/PluginDso.cc b/proxy/http/remap/PluginDso.cc
index d4467b8ce72..eb600a5f0e9 100644
--- a/proxy/http/remap/PluginDso.cc
+++ b/proxy/http/remap/PluginDso.cc
@@ -125,8 +125,6 @@ PluginDso::load(std::string &error)
 bool
 PluginDso::unload(std::string &error)
 {
-  /* clean errors */
-  error.clear();
   bool result = false;
 
   if (isLoaded()) {
@@ -158,7 +156,6 @@ PluginDso::getSymbol(const char *symbol, void *&address, std::string &error) con
 {
   /* Clear the errors */
   dlerror();
-  error.clear();
 
   address   = dlsym(_dlh, symbol);
   char *err = dlerror();