diff --git a/include/ts/ts.h b/include/ts/ts.h index b612f6b9ef6..92af612600d 100644 --- a/include/ts/ts.h +++ b/include/ts/ts.h @@ -2083,8 +2083,7 @@ tsapi struct sockaddr const *TSNetVConnLocalAddrGet(TSVConn vc); /* -------------------------------------------------------------------------- Stats and configs based on librecords raw stats (this is preferred API until we - rewrite stats). This system has a limitation of up to 1,500 stats max, controlled - via proxy.config.stat_api.max_stats_allowed (default is 512). + rewrite stats). This is available as of Apache TS v2.2.*/ typedef enum { diff --git a/iocore/eventsystem/I_EThread.h b/iocore/eventsystem/I_EThread.h index eb3d282ef74..799d90609c3 100644 --- a/iocore/eventsystem/I_EThread.h +++ b/iocore/eventsystem/I_EThread.h @@ -32,8 +32,7 @@ #include "I_ProtectedQueue.h" #include "tscpp/util/Histogram.h" -// TODO: This would be much nicer to have "run-time" configurable (or something), -// perhaps based on proxy.config.stat_api.max_stats_allowed or other configs. XXX +// TODO: This would be much nicer to have "run-time" configurable (or something) #define PER_THREAD_DATA (1024 * 1024) // This is not used by the cache anymore, it uses proxy.config.cache.mutex_retry_delay diff --git a/src/records/RecordsConfig.cc b/src/records/RecordsConfig.cc index dc6b6a5d543..65fd3e719c1 100644 --- a/src/records/RecordsConfig.cc +++ b/src/records/RecordsConfig.cc @@ -1498,10 +1498,6 @@ static const RecordElement RecordsConfig[] = {RECT_LOCAL, "proxy.config.outgoing_ip_to_bind", RECD_STRING, nullptr, RECU_NULL, RR_NULL, RECC_NULL, nullptr, RECA_NULL} , - //# Librecords based stats system (new as of v2.1.3) - {RECT_CONFIG, "proxy.config.stat_api.max_stats_allowed", RECD_INT, "256", RECU_RESTART_TS, RR_NULL, RECC_INT, "[256-1000]", RECA_NULL} - , - //############ //# //# Per-thread freelist / allocator controls diff --git a/tests/gold_tests/records/gold/full_records.yaml b/tests/gold_tests/records/gold/full_records.yaml index d58d395ac54..fea30087dbf 100644 --- a/tests/gold_tests/records/gold/full_records.yaml +++ b/tests/gold_tests/records/gold/full_records.yaml @@ -575,8 +575,6 @@ ts: skip_cache_on_bucket_contention: 0 timeout: 0 value: 2 - stat_api: - max_stats_allowed: 256 stop: shutdown_timeout: 0 system: diff --git a/tests/gold_tests/records/legacy_config/full_records.config b/tests/gold_tests/records/legacy_config/full_records.config index f75f63071e2..fe80a459e13 100644 --- a/tests/gold_tests/records/legacy_config/full_records.config +++ b/tests/gold_tests/records/legacy_config/full_records.config @@ -483,7 +483,6 @@ CONFIG proxy.config.quic.congestion_control.loss_reduction_factor FLOAT 0.5 CONFIG proxy.config.quic.congestion_control.persistent_congestion_threshold INT 3 CONFIG proxy.config.incoming_ip_to_bind STRING nullptr CONFIG proxy.config.outgoing_ip_to_bind STRING nullptr -CONFIG proxy.config.stat_api.max_stats_allowed INT 256 CONFIG proxy.config.allocator.thread_freelist_size INT 512 CONFIG proxy.config.allocator.thread_freelist_low_watermark INT 32 CONFIG proxy.config.allocator.hugepages INT 0