From a2333c81c9ed3ac5f11e0b27b189520403baf56e Mon Sep 17 00:00:00 2001 From: Qingchao Shen Date: Tue, 13 Jun 2023 13:59:16 +0800 Subject: [PATCH 1/3] fix wrong assertion about unsample in keras.py --- python/tvm/relay/frontend/keras.py | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/python/tvm/relay/frontend/keras.py b/python/tvm/relay/frontend/keras.py index 16192617fe13..d963a5d160bf 100644 --- a/python/tvm/relay/frontend/keras.py +++ b/python/tvm/relay/frontend/keras.py @@ -767,10 +767,8 @@ def _convert_upsample( params["scale_h"] = h elif upsample_type == "UpSampling2D": h, w = keras_layer.size - if h != w: - raise tvm.error.OpAttributeInvalid("Height must equal width for operator Upsample.") params["scale_h"] = h - params["scale_w"] = h + params["scale_w"] = w if hasattr(keras_layer, "interpolation"): interpolation = keras_layer.interpolation From 4dcd6826524a48852860fc52c256db553147a4a7 Mon Sep 17 00:00:00 2001 From: Qingchao Shen Date: Tue, 13 Jun 2023 14:02:36 +0800 Subject: [PATCH 2/3] Update test_forward.py --- tests/python/frontend/keras/test_forward.py | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/tests/python/frontend/keras/test_forward.py b/tests/python/frontend/keras/test_forward.py index debd50b37a2e..d36befef3a8b 100644 --- a/tests/python/frontend/keras/test_forward.py +++ b/tests/python/frontend/keras/test_forward.py @@ -389,6 +389,11 @@ def test_forward_upsample(self, keras_mod, interpolation="nearest"): x = keras_mod.layers.UpSampling2D(size=(3, 3), interpolation=interpolation)(data) keras_model = keras_mod.models.Model(data, x) verify_keras_frontend(keras_model) + # Height and width are not equal for the attribute size + data = keras_mod.layers.Input(shape=(2, 2, 1, 3)) + x = keras_mod.layers.UpSampling2D(size=(1, 2), interpolation=interpolation)(data) + keras_model = keras_mod.models.Model(data, x) + verify_keras_frontend(keras_model) def test_forward_reshape(self, keras_mod): """test_forward_reshape""" From c6163a69bf6d913adc66b8e1959bb966607117f1 Mon Sep 17 00:00:00 2001 From: Qingchao Shen Date: Tue, 13 Jun 2023 17:14:41 +0800 Subject: [PATCH 3/3] Update test_forward.py --- tests/python/frontend/keras/test_forward.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/python/frontend/keras/test_forward.py b/tests/python/frontend/keras/test_forward.py index d36befef3a8b..45935f87f4f4 100644 --- a/tests/python/frontend/keras/test_forward.py +++ b/tests/python/frontend/keras/test_forward.py @@ -390,7 +390,7 @@ def test_forward_upsample(self, keras_mod, interpolation="nearest"): keras_model = keras_mod.models.Model(data, x) verify_keras_frontend(keras_model) # Height and width are not equal for the attribute size - data = keras_mod.layers.Input(shape=(2, 2, 1, 3)) + data = keras_mod.layers.Input(shape=(2, 1, 3)) x = keras_mod.layers.UpSampling2D(size=(1, 2), interpolation=interpolation)(data) keras_model = keras_mod.models.Model(data, x) verify_keras_frontend(keras_model)