From 3c0a12dc0a5b3d8d280ab3d9a5311591e805e566 Mon Sep 17 00:00:00 2001 From: Gustavo Romero Date: Tue, 25 May 2021 19:39:05 +0000 Subject: [PATCH 1/2] Fix typos and format in comments Fix typos and format in comments about the registry manager of packed functions. Signed-off-by: Gustavo Romero --- src/runtime/registry.cc | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/runtime/registry.cc b/src/runtime/registry.cc index 1a963bee472c..aabe9b058086 100644 --- a/src/runtime/registry.cc +++ b/src/runtime/registry.cc @@ -38,9 +38,9 @@ namespace runtime { struct Registry::Manager { // map storing the functions. - // We deliberately used raw pointer - // This is because PackedFunc can contain callbacks into the host languge(python) - // and the resource can become invalid because of indeterminstic order of destruction and forking. + // We deliberately used raw pointer. + // This is because PackedFunc can contain callbacks into the host language (Python) + // and the resource can become invalid because of indeterministic order of destruction and forking. // The resources will only be recycled during program exit. std::unordered_map fmap; // mutex From 795a465fa4072967bcc936f26f7600141e467cc4 Mon Sep 17 00:00:00 2001 From: Gustavo Romero Date: Tue, 25 May 2021 21:16:44 +0000 Subject: [PATCH 2/2] Fix lint No more than 100 characters per line is allowed. --- src/runtime/registry.cc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/runtime/registry.cc b/src/runtime/registry.cc index aabe9b058086..fa09720fc90d 100644 --- a/src/runtime/registry.cc +++ b/src/runtime/registry.cc @@ -39,8 +39,8 @@ namespace runtime { struct Registry::Manager { // map storing the functions. // We deliberately used raw pointer. - // This is because PackedFunc can contain callbacks into the host language (Python) - // and the resource can become invalid because of indeterministic order of destruction and forking. + // This is because PackedFunc can contain callbacks into the host language (Python) and the + // resource can become invalid because of indeterministic order of destruction and forking. // The resources will only be recycled during program exit. std::unordered_map fmap; // mutex