From eaf09b4f59ee599d7ec43bfff253d36bb52da98e Mon Sep 17 00:00:00 2001 From: John Huebner Date: Sun, 22 Nov 2015 11:06:10 -0500 Subject: [PATCH 1/2] add more data --- checkipa | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/checkipa b/checkipa index 78fffaf..a9376b4 100755 --- a/checkipa +++ b/checkipa @@ -233,9 +233,12 @@ class IntegrityCheck(object): if 'CFBundleName' in self.data: txt.append(' Name: %s' % (self.data['CFBundleName'])) - + if 'CFBundleIdentifier' in self.data: + txt.append(' BundleID: %s' % (self.data['CFBundleIdentifier'])) + if 'CFBundleShortVersionString' in self.data: + txt.append(' Release Version: %s' % (self.data['CFBundleShortVersionString'])) if 'CFBundleVersion' in self.data: - txt.append(' Version: %s' % (self.data['CFBundleVersion'])) + txt.append(' Build Version: %s' % (self.data['CFBundleVersion'])) if ('ExpirationDate' in self.profile): txt.append(' Expiration Date: %s' % (self.profile['ExpirationDate'])) From a53c3fa4236dce722a83b5b5e567a7a3af243c37 Mon Sep 17 00:00:00 2001 From: John Huebner Date: Sun, 22 Nov 2015 12:14:56 -0500 Subject: [PATCH 2/2] remove check_push and add provision fields --- checkipa | 16 ++++++++++++---- 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/checkipa b/checkipa index a9376b4..3b8fcf2 100755 --- a/checkipa +++ b/checkipa @@ -159,7 +159,7 @@ class IntegrityCheck(object): 'description': 'formatted incorrectly'}) if self.errors['appid_bundleseed_mismatch']: - appid_parts = self.profile['Entitlements']['application-identifier'].split('.', 1) + appid_parts = self.profile['Entitlements']['/out_'].split('.', 1) appid_suffix = appid_parts[1] bundleid_val = self.data['CFBundleIdentifier'] desc = 'BundleID "%s" does not match AppID "%s"' % (bundleid_val, appid_suffix) @@ -239,7 +239,12 @@ class IntegrityCheck(object): txt.append(' Release Version: %s' % (self.data['CFBundleShortVersionString'])) if 'CFBundleVersion' in self.data: txt.append(' Build Version: %s' % (self.data['CFBundleVersion'])) - + if ('Name' in self.profile): + txt.append(' Profile Name: %s' % (self.profile['Name'])) + if ('application-identifier' in self.profile['Entitlements']): + txt.append(' profile application-identifier: %s' % (self.profile['Entitlements']['application-identifier'])) + else: + txt.append(' profile application-identifier: %s' % ("unknown")) if ('ExpirationDate' in self.profile): txt.append(' Expiration Date: %s' % (self.profile['ExpirationDate'])) @@ -285,6 +290,7 @@ class IntegrityCheck(object): for line in txt: print(' %s' % (line)) + # end output_report @@ -298,10 +304,11 @@ class IntegrityCheck(object): self.check_bundle_id() self.check_bundle_seed() self.check_appid() - self.check_push() + #self.check_push() self.check_dist_method() self.check_dist_profile() self.check_expiration_date() + # self.check_executable_size() def check_expiration_date(self): if ('ExpirationDate' in self.profile): @@ -464,7 +471,8 @@ class IntegrityCheck(object): elif 'ProvisionedDevices' in self.profile: self.ipa_info['adhoc'] = True else: - self.errors['distmethod'] = True + self.ipa_info['app_store'] = True + #self.errors['distmethod'] = True def _initialize_results_data(self): # All errors and warnings are to be declared here and set to