Skip to content

Commit bab90bc

Browse files
committed
fix: Fix Selenium 4.40.0+ compatibility
1 parent 7fed7ea commit bab90bc

File tree

3 files changed

+7
-6
lines changed

3 files changed

+7
-6
lines changed

README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -100,8 +100,8 @@ dependencies {
100100
### Compatibility Matrix
101101
Appium Java Client | Selenium client
102102
----------------------------------------------------------------------------------------------------|-----------------------------
103-
`next` (not released yet) | `4.36.0`
104-
`10.0.0` | `4.35.0`, `4.36.0`
103+
`next` (not released yet) | `4.40.0`
104+
`10.0.0` | `4.35.0`, `4.36.0`, `4.37.0`, `4.38.0`, `4.39.0`
105105
`9.5.0` | `4.34.0`
106106
`9.4.0` | `4.26.0`, `4.27.0`, `4.28.0`, `4.28.1`, `4.29.0`, `4.30.0`, `4.31.0`, `4.32.0`, `4.33.0`
107107
`9.2.1`(known issues: appium/java-client#2145, appium/java-client#2146), `9.2.2`, `9.2.3`, `9.3.0` | `4.19.0`, `4.19.1`, `4.20.0`, `4.21.0`, `4.22.0`, `4.23.0`, `4.23.1`, `4.24.0`, `4.25.0`, `4.26.0`, `4.27.0`

gradle.properties

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
org.gradle.daemon=true
22

3-
selenium.version=4.36.0
3+
selenium.version=4.40.0
44
# Please increment the value in a release
55
appiumClient.version=10.0.0

src/main/java/io/appium/java_client/AppiumDriver.java

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -413,14 +413,15 @@ private void initBiDi(BaseOptions<?> responseCaps) {
413413
}
414414
var executor = getCommandExecutor();
415415
final HttpClient wsClient;
416+
AppiumClientConfig wsConfig;
416417
if (executor instanceof AppiumCommandExecutor) {
417-
var wsConfig = ((AppiumCommandExecutor) executor).getAppiumClientConfig().baseUri(biDiUri);
418+
wsConfig = ((AppiumCommandExecutor) executor).getAppiumClientConfig().baseUri(biDiUri);
418419
wsClient = ((AppiumCommandExecutor) executor).getHttpClientFactory().createClient(wsConfig);
419420
} else {
420-
var wsConfig = AppiumClientConfig.defaultConfig().baseUri(biDiUri);
421+
wsConfig = AppiumClientConfig.defaultConfig().baseUri(biDiUri);
421422
wsClient = HttpClient.Factory.createDefault().createClient(wsConfig);
422423
}
423424
var biDiConnection = new org.openqa.selenium.bidi.Connection(wsClient, biDiUri.toString());
424-
this.biDi = new BiDi(biDiConnection);
425+
this.biDi = new BiDi(biDiConnection, wsConfig.wsTimeout());
425426
}
426427
}

0 commit comments

Comments
 (0)