From 981a22f626e336daceb76176f1638806da934557 Mon Sep 17 00:00:00 2001 From: Alessandro Miccoli Date: Thu, 31 Aug 2023 13:20:22 +0100 Subject: [PATCH 1/2] ISSUE_1991 feat: add automation name Chromium for Chromium driver --- PULL_REQUEST_TEMPLATE.md | 2 +- src/main/java/io/appium/java_client/remote/AutomationName.java | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/PULL_REQUEST_TEMPLATE.md b/PULL_REQUEST_TEMPLATE.md index 31e5a4707..632ac1813 100644 --- a/PULL_REQUEST_TEMPLATE.md +++ b/PULL_REQUEST_TEMPLATE.md @@ -9,7 +9,7 @@ _Put an `x` in the boxes that apply_ - [ ] No changes in production code. - [ ] Bugfix (non-breaking change which fixes an issue) -- [ ] New feature (non-breaking change which adds functionality) +- [x] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) diff --git a/src/main/java/io/appium/java_client/remote/AutomationName.java b/src/main/java/io/appium/java_client/remote/AutomationName.java index e38474dbc..4ee53ea1a 100644 --- a/src/main/java/io/appium/java_client/remote/AutomationName.java +++ b/src/main/java/io/appium/java_client/remote/AutomationName.java @@ -34,6 +34,8 @@ public interface AutomationName { String SAFARI = "Safari"; // https://github.com/appium/appium-geckodriver String GECKO = "Gecko"; + // https://github.com/appium/appium-chromium-driver + String CHROMIUM = "Chromium"; // Third-party drivers // https://github.com/YOU-i-Labs/appium-youiengine-driver From a25cbb54a70b9d8fac72fe199a53e24d2987c474 Mon Sep 17 00:00:00 2001 From: Alessandro Miccoli Date: Thu, 31 Aug 2023 13:32:22 +0100 Subject: [PATCH 2/2] ISSUE_1991 fix: remove x in PULL_REQUEST_TEMPLATE file --- PULL_REQUEST_TEMPLATE.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/PULL_REQUEST_TEMPLATE.md b/PULL_REQUEST_TEMPLATE.md index 632ac1813..31e5a4707 100644 --- a/PULL_REQUEST_TEMPLATE.md +++ b/PULL_REQUEST_TEMPLATE.md @@ -9,7 +9,7 @@ _Put an `x` in the boxes that apply_ - [ ] No changes in production code. - [ ] Bugfix (non-breaking change which fixes an issue) -- [x] New feature (non-breaking change which adds functionality) +- [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)