From fc85b57fdc9e0812069a03ecd3cf60093c9b92e7 Mon Sep 17 00:00:00 2001 From: Mykola Mokhnach Date: Mon, 6 Jan 2025 23:09:24 +0100 Subject: [PATCH 1/2] test: Reenable BiDi logging tests for iOS --- .../appium/java_client/ios/IOSBiDiTest.java | 21 ++++++++++++++++--- 1 file changed, 18 insertions(+), 3 deletions(-) diff --git a/src/e2eIosTest/java/io/appium/java_client/ios/IOSBiDiTest.java b/src/e2eIosTest/java/io/appium/java_client/ios/IOSBiDiTest.java index e25d3f515..1a72394ec 100644 --- a/src/e2eIosTest/java/io/appium/java_client/ios/IOSBiDiTest.java +++ b/src/e2eIosTest/java/io/appium/java_client/ios/IOSBiDiTest.java @@ -16,8 +16,8 @@ package io.appium.java_client.ios; -import org.junit.jupiter.api.Disabled; import org.junit.jupiter.api.Test; +import org.openqa.selenium.bidi.Event; import org.openqa.selenium.bidi.log.LogEntry; import org.openqa.selenium.bidi.module.LogInspector; @@ -29,8 +29,23 @@ public class IOSBiDiTest extends AppIOSTest { @Test - @Disabled("Need to resolve compatibility issues") - public void listenForIosLogs() { + public void listenForIosLogsGeneric() { + var logs = new CopyOnWriteArrayList<>(); + var listenerId = driver.getBiDi().addListener( + NATIVE_CONTEXT, + new Event("log.entryAdded", (m) -> m), + logs::add + ); + try { + driver.getPageSource(); + } finally { + driver.getBiDi().removeListener(listenerId); + } + assertFalse(logs.isEmpty()); + } + + @Test + public void listenForIosLogsSpecific() { var logs = new CopyOnWriteArrayList(); try (var logInspector = new LogInspector(NATIVE_CONTEXT, driver)) { logInspector.onLog(logs::add); From b2174e4f659d1f2578e4fce5bb69ee144057cfe1 Mon Sep 17 00:00:00 2001 From: Mykola Mokhnach Date: Tue, 7 Jan 2025 10:42:25 +0100 Subject: [PATCH 2/2] checkstyle --- src/e2eIosTest/java/io/appium/java_client/ios/IOSBiDiTest.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/e2eIosTest/java/io/appium/java_client/ios/IOSBiDiTest.java b/src/e2eIosTest/java/io/appium/java_client/ios/IOSBiDiTest.java index 1a72394ec..d6288165d 100644 --- a/src/e2eIosTest/java/io/appium/java_client/ios/IOSBiDiTest.java +++ b/src/e2eIosTest/java/io/appium/java_client/ios/IOSBiDiTest.java @@ -33,7 +33,7 @@ public void listenForIosLogsGeneric() { var logs = new CopyOnWriteArrayList<>(); var listenerId = driver.getBiDi().addListener( NATIVE_CONTEXT, - new Event("log.entryAdded", (m) -> m), + new Event("log.entryAdded", m -> m), logs::add ); try {