[FIX-ME] Complete overload writeValue

Author: polldo

src/BLECharacteristic.cpp

@@ -252,47 +252,47 @@ int BLECharacteristic::writeValue(const void* value, int length, bool withRespon
   return writeValue((const uint8_t*)value, length, withResponse);
 }
 
-int BLECharacteristic::writeValue(const char* value)
+int BLECharacteristic::writeValue(const char* value, bool withResponse)
 {
   if (_local) {
     return _local->writeValue(value);
   }
 
   if (_remote) {
-    return _remote->writeValue(value);
+    return _remote->writeValue(value, withResponse);
   }
 
   return 0;
 }
 
-int BLECharacteristic::writeValue(uint8_t value)
+int BLECharacteristic::writeValue(uint8_t value, bool withResponse)
 {
-  return writeValue((uint8_t*)&value, sizeof(value));
+  return writeValue((uint8_t*)&value, sizeof(value), withResponse);
 }
 
-int BLECharacteristic::writeValue(int8_t value)
+int BLECharacteristic::writeValue(int8_t value, bool withResponse)
 {
-  return writeValue((uint8_t*)&value, sizeof(value));
+  return writeValue((uint8_t*)&value, sizeof(value), withResponse);
 }
 
-int BLECharacteristic::writeValue(uint16_t value)
+int BLECharacteristic::writeValue(uint16_t value, bool withResponse)
 {
-  return writeValue((uint8_t*)&value, sizeof(value));
+  return writeValue((uint8_t*)&value, sizeof(value), withResponse);
 }
 
-int BLECharacteristic::writeValue(int16_t value)
+int BLECharacteristic::writeValue(int16_t value, bool withResponse)
 {
-  return writeValue((uint8_t*)&value, sizeof(value));
+  return writeValue((uint8_t*)&value, sizeof(value), withResponse);
 }
 
-int BLECharacteristic::writeValue(uint32_t value)
+int BLECharacteristic::writeValue(uint32_t value, bool withResponse)
 {
-  return writeValue((uint8_t*)&value, sizeof(value));
+  return writeValue((uint8_t*)&value, sizeof(value), withResponse);
 }
 
-int BLECharacteristic::writeValue(int32_t value)
+int BLECharacteristic::writeValue(int32_t value, bool withResponse)
 {
-  return writeValue((uint8_t*)&value, sizeof(value));
+  return writeValue((uint8_t*)&value, sizeof(value), withResponse);
 }
 
 int BLECharacteristic::broadcast()

src/BLECharacteristic.h

@@ -70,13 +70,13 @@ class BLECharacteristic  {
 
   int writeValue(const uint8_t value[], int length, bool withResponse = true);
   int writeValue(const void* value, int length, bool withResponse = true);
-  int writeValue(const char* value);
-  int writeValue(uint8_t value);
-  int writeValue(int8_t value);
-  int writeValue(uint16_t value);
-  int writeValue(int16_t value);
-  int writeValue(uint32_t value);
-  int writeValue(int32_t value);
+  int writeValue(const char* value, bool withResponse = true);
+  int writeValue(uint8_t value, bool withResponse = true);
+  int writeValue(int8_t value, bool withResponse = true);
+  int writeValue(uint16_t value, bool withResponse = true);
+  int writeValue(int16_t value, bool withResponse = true);
+  int writeValue(uint32_t value, bool withResponse = true);
+  int writeValue(int32_t value, bool withResponse = true);
 
   // deprecated, use writeValue(...)
   int setValue(const uint8_t value[], int length) { return writeValue(value, length); }

src/remote/BLERemoteCharacteristic.cpp

@@ -133,9 +133,9 @@ int BLERemoteCharacteristic::writeValue(const uint8_t value[], int length, bool
   return 0;
 }
 
-int BLERemoteCharacteristic::writeValue(const char* value)
+int BLERemoteCharacteristic::writeValue(const char* value, bool withResponse)
 {
-  return writeValue((uint8_t*)value, strlen(value));
+  return writeValue((uint8_t*)value, strlen(value), withResponse);
 }
 
 bool BLERemoteCharacteristic::valueUpdated()

src/remote/BLERemoteCharacteristic.h

@@ -39,7 +39,7 @@ class BLERemoteCharacteristic : public BLERemoteAttribute {
   uint8_t operator[] (int offset) const;
 
   int writeValue(const uint8_t value[], int length, bool withResponse = true);
-  int writeValue(const char* value);
+  int writeValue(const char* value, bool withResponse = true);
 
   bool valueUpdated();
   bool updatedValueRead();