Libraries (un)installation name inconcistency

Now,  the "_" is replaced with a blanket " ", to reslove the
inconsistency problem. However, use the name of the installing
library may be a better solution.

Author: howjmay

arduino/libraries/loader.go

@@ -96,7 +96,7 @@ func makeNewLibrary(libraryDir *paths.Path, location LibraryLocation) (*Library,
 		library.Version = v
 	}
 
-	library.Name = libraryDir.Base()
+	library.Name = strings.ReplaceAll(libraryDir.Base(), "_", " ")
 	library.RealName = strings.TrimSpace(libProperties.Get("name"))
 	library.Author = strings.TrimSpace(libProperties.Get("author"))
 	library.Maintainer = strings.TrimSpace(libProperties.Get("maintainer"))

legacy/builder/test/libraries_loader_test.go

@@ -89,7 +89,7 @@ func TestLoadLibrariesAVR(t *testing.T) {
 	require.Equal(t, "ANewLibrary-master", libs[idx].Name)
 
 	idx++
-	require.Equal(t, "Adafruit_PN532", libs[idx].Name)
+	require.Equal(t, "Adafruit PN532", libs[idx].Name)
 	require.True(t, Abs(t, paths.New("downloaded_libraries/Adafruit_PN532")).EquivalentTo(libs[idx].InstallDir))
 	require.True(t, Abs(t, paths.New("downloaded_libraries/Adafruit_PN532")).EquivalentTo(libs[idx].SourceDir))
 	require.Equal(t, 1, len(libs[idx].Architectures))
@@ -128,7 +128,7 @@ func TestLoadLibrariesAVR(t *testing.T) {
 	idx++
 	require.Equal(t, "IRremote", libs[idx].Name)
 	idx++
-	require.Equal(t, "Robot_IR_Remote", libs[idx].Name)
+	require.Equal(t, "Robot IR Remote", libs[idx].Name)
 	idx++
 	require.Equal(t, "SPI", libs[idx].Name)
 	idx++
@@ -154,7 +154,7 @@ func TestLoadLibrariesAVR(t *testing.T) {
 
 	libs = ctx.LibrariesResolver.AlternativesFor("Adafruit_PN532.h")
 	require.Len(t, libs, 1)
-	require.Equal(t, "Adafruit_PN532", libs[0].Name)
+	require.Equal(t, "Adafruit PN532", libs[0].Name)
 
 	libs = ctx.LibrariesResolver.AlternativesFor("IRremote.h")
 	require.Len(t, libs, 1)
@@ -197,7 +197,7 @@ func TestLoadLibrariesSAM(t *testing.T) {
 	idx := 0
 	require.Equal(t, "ANewLibrary-master", libraries[idx].Name)
 	idx++
-	require.Equal(t, "Adafruit_PN532", libraries[idx].Name)
+	require.Equal(t, "Adafruit PN532", libraries[idx].Name)
 	idx++
 	require.Equal(t, "Audio", libraries[idx].Name)
 	idx++
@@ -217,7 +217,7 @@ func TestLoadLibrariesSAM(t *testing.T) {
 	idx++
 	require.Equal(t, "IRremote", libraries[idx].Name)
 	idx++
-	require.Equal(t, "Robot_IR_Remote", libraries[idx].Name)
+	require.Equal(t, "Robot IR Remote", libraries[idx].Name)
 	idx++
 	require.Equal(t, "SPI", libraries[idx].Name)
 	idx++