Removed unused parameter

Author: cmaglie

legacy/builder/builder_utils/utils.go

@@ -210,7 +210,7 @@ func compileFileWithRecipe(ctx *types.Context, sourcePath *paths.Path, source *p
 		return nil, errors.WithStack(err)
 	}
 
-	objIsUpToDate, err := ObjFileIsUpToDate(ctx, source, objectFile, depsFile)
+	objIsUpToDate, err := ObjFileIsUpToDate(source, objectFile, depsFile)
 	if err != nil {
 		return nil, errors.WithStack(err)
 	}
@@ -237,7 +237,7 @@ func compileFileWithRecipe(ctx *types.Context, sourcePath *paths.Path, source *p
 	return objectFile, nil
 }
 
-func ObjFileIsUpToDate(ctx *types.Context, sourceFile, objectFile, dependencyFile *paths.Path) (bool, error) {
+func ObjFileIsUpToDate(sourceFile, objectFile, dependencyFile *paths.Path) (bool, error) {
 	logrus.Debugf("Checking previous results for %v (result = %v, dep = %v)", sourceFile, objectFile, dependencyFile)
 	if objectFile == nil || dependencyFile == nil {
 		logrus.Debugf("Not found: nil")

legacy/builder/container_find_includes.go

@@ -312,7 +312,7 @@ func findIncludesUntilDone(ctx *types.Context, cache *includeCache, sourceFile t
 	// TODO: This reads the dependency file, but the actual building
 	// does it again. Should the result be somehow cached? Perhaps
 	// remove the object file if it is found to be stale?
-	unchanged, err := builder_utils.ObjFileIsUpToDate(ctx, sourcePath, objPath, depPath)
+	unchanged, err := builder_utils.ObjFileIsUpToDate(sourcePath, objPath, depPath)
 	if err != nil {
 		return errors.WithStack(err)
 	}

legacy/builder/test/builder_utils_test.go

@@ -21,7 +21,6 @@ import (
 	"time"
 
 	"github.com/arduino/arduino-cli/legacy/builder/builder_utils"
-	"github.com/arduino/arduino-cli/legacy/builder/types"
 	paths "github.com/arduino/go-paths-helper"
 	"github.com/stretchr/testify/require"
 )
@@ -40,33 +39,27 @@ func tempFile(t *testing.T, prefix string) *paths.Path {
 }
 
 func TestObjFileIsUpToDateObjMissing(t *testing.T) {
-	ctx := &types.Context{}
-
 	sourceFile := tempFile(t, "source")
 	defer sourceFile.RemoveAll()
 
-	upToDate, err := builder_utils.ObjFileIsUpToDate(ctx, sourceFile, nil, nil)
+	upToDate, err := builder_utils.ObjFileIsUpToDate(sourceFile, nil, nil)
 	NoError(t, err)
 	require.False(t, upToDate)
 }
 
 func TestObjFileIsUpToDateDepMissing(t *testing.T) {
-	ctx := &types.Context{}
-
 	sourceFile := tempFile(t, "source")
 	defer sourceFile.RemoveAll()
 
 	objFile := tempFile(t, "obj")
 	defer objFile.RemoveAll()
 
-	upToDate, err := builder_utils.ObjFileIsUpToDate(ctx, sourceFile, objFile, nil)
+	upToDate, err := builder_utils.ObjFileIsUpToDate(sourceFile, objFile, nil)
 	NoError(t, err)
 	require.False(t, upToDate)
 }
 
 func TestObjFileIsUpToDateObjOlder(t *testing.T) {
-	ctx := &types.Context{}
-
 	objFile := tempFile(t, "obj")
 	defer objFile.RemoveAll()
 	depFile := tempFile(t, "dep")
@@ -77,14 +70,12 @@ func TestObjFileIsUpToDateObjOlder(t *testing.T) {
 	sourceFile := tempFile(t, "source")
 	defer sourceFile.RemoveAll()
 
-	upToDate, err := builder_utils.ObjFileIsUpToDate(ctx, sourceFile, objFile, depFile)
+	upToDate, err := builder_utils.ObjFileIsUpToDate(sourceFile, objFile, depFile)
 	NoError(t, err)
 	require.False(t, upToDate)
 }
 
 func TestObjFileIsUpToDateObjNewer(t *testing.T) {
-	ctx := &types.Context{}
-
 	sourceFile := tempFile(t, "source")
 	defer sourceFile.RemoveAll()
 
@@ -95,14 +86,12 @@ func TestObjFileIsUpToDateObjNewer(t *testing.T) {
 	depFile := tempFile(t, "dep")
 	defer depFile.RemoveAll()
 
-	upToDate, err := builder_utils.ObjFileIsUpToDate(ctx, sourceFile, objFile, depFile)
+	upToDate, err := builder_utils.ObjFileIsUpToDate(sourceFile, objFile, depFile)
 	NoError(t, err)
 	require.True(t, upToDate)
 }
 
 func TestObjFileIsUpToDateDepIsNewer(t *testing.T) {
-	ctx := &types.Context{}
-
 	sourceFile := tempFile(t, "source")
 	defer sourceFile.RemoveAll()
 
@@ -121,14 +110,12 @@ func TestObjFileIsUpToDateDepIsNewer(t *testing.T) {
 	data := objFile.String() + ": \\\n\t" + sourceFile.String() + " \\\n\t" + headerFile.String()
 	depFile.WriteFile([]byte(data))
 
-	upToDate, err := builder_utils.ObjFileIsUpToDate(ctx, sourceFile, objFile, depFile)
+	upToDate, err := builder_utils.ObjFileIsUpToDate(sourceFile, objFile, depFile)
 	NoError(t, err)
 	require.False(t, upToDate)
 }
 
 func TestObjFileIsUpToDateDepIsOlder(t *testing.T) {
-	ctx := &types.Context{}
-
 	sourceFile := tempFile(t, "source")
 	defer sourceFile.RemoveAll()
 
@@ -145,14 +132,12 @@ func TestObjFileIsUpToDateDepIsOlder(t *testing.T) {
 	res := objFile.String() + ": \\\n\t" + sourceFile.String() + " \\\n\t" + headerFile.String()
 	depFile.WriteFile([]byte(res))
 
-	upToDate, err := builder_utils.ObjFileIsUpToDate(ctx, sourceFile, objFile, depFile)
+	upToDate, err := builder_utils.ObjFileIsUpToDate(sourceFile, objFile, depFile)
 	NoError(t, err)
 	require.True(t, upToDate)
 }
 
 func TestObjFileIsUpToDateDepIsWrong(t *testing.T) {
-	ctx := &types.Context{}
-
 	sourceFile := tempFile(t, "source")
 	defer sourceFile.RemoveAll()
 
@@ -171,7 +156,7 @@ func TestObjFileIsUpToDateDepIsWrong(t *testing.T) {
 	res := sourceFile.String() + ": \\\n\t" + sourceFile.String() + " \\\n\t" + headerFile.String()
 	depFile.WriteFile([]byte(res))
 
-	upToDate, err := builder_utils.ObjFileIsUpToDate(ctx, sourceFile, objFile, depFile)
+	upToDate, err := builder_utils.ObjFileIsUpToDate(sourceFile, objFile, depFile)
 	NoError(t, err)
 	require.False(t, upToDate)
 }