instance.Init no longer return errors array.

They are printed directly inside the function through the feedback
package.

Author: cmaglie

cli/core/search.go

@@ -73,9 +73,7 @@ func runSearchCommand(cmd *cobra.Command, args []string) {
 		}
 	}
 
-	for _, err := range instance.Init(inst) {
-		feedback.Errorf(tr("Error initializing instance: %v"), err)
-	}
+	instance.Init(inst)
 
 	arguments := strings.ToLower(strings.Join(args, " "))
 	logrus.Infof("Executing `arduino-cli core search` with args: '%s'", arguments)

cli/instance/instance.go

@@ -17,7 +17,6 @@ package instance
 
 import (
 	"context"
-	"errors"
 	"os"
 
 	"github.com/arduino/arduino-cli/cli/errorcodes"
@@ -50,10 +49,7 @@ func CreateAndInitWithProfile(profileName string, sketchPath *paths.Path) (*rpc.
 		feedback.Errorf(tr("Error creating instance: %v"), err)
 		os.Exit(errorcodes.ErrGeneric)
 	}
-	profile, errs := InitWithProfile(instance, profileName, sketchPath)
-	for _, err := range errs {
-		feedback.Errorf(tr("Error initializing instance: %v"), err)
-	}
+	profile := InitWithProfile(instance, profileName, sketchPath)
 	return instance, profile
 }
 
@@ -71,20 +67,18 @@ func Create() (*rpc.Instance, error) {
 // platform or library that we failed to load.
 // Package and library indexes files are automatically updated if the
 // CLI is run for the first time.
-func Init(instance *rpc.Instance) []error {
-	_, errs := InitWithProfile(instance, "", nil)
-	return errs
+func Init(instance *rpc.Instance) {
+	InitWithProfile(instance, "", nil)
 }
 
 // InitWithProfile initializes instance by loading libraries and platforms specified in the given profile of the given sketch.
 // In case of loading failures return a list of errors for each platform or library that we failed to load.
 // Required Package and library indexes files are automatically downloaded.
-func InitWithProfile(instance *rpc.Instance, profileName string, sketchPath *paths.Path) (*rpc.Profile, []error) {
-	errs := []error{}
-
+func InitWithProfile(instance *rpc.Instance, profileName string, sketchPath *paths.Path) *rpc.Profile {
 	// In case the CLI is executed for the first time
 	if err := FirstUpdate(instance); err != nil {
-		return nil, append(errs, err)
+		feedback.Errorf(tr("Error initializing instance: %v"), err)
+		return nil
 	}
 
 	downloadCallback := output.ProgressBar()
@@ -98,7 +92,7 @@ func InitWithProfile(instance *rpc.Instance, profileName string, sketchPath *pat
 	var profile *rpc.Profile
 	err := commands.Init(initReq, func(res *rpc.InitResponse) {
 		if st := res.GetError(); st != nil {
-			errs = append(errs, errors.New(st.Message))
+			feedback.Errorf(tr("Error initializing instance: %v"), st.Message)
 		}
 
 		if progress := res.GetInitProgress(); progress != nil {
@@ -115,10 +109,10 @@ func InitWithProfile(instance *rpc.Instance, profileName string, sketchPath *pat
 		}
 	})
 	if err != nil {
-		errs = append(errs, err)
+		feedback.Errorf(tr("Error initializing instance: %v"), err)
 	}
 
-	return profile, errs
+	return profile
 }
 
 // FirstUpdate downloads libraries and packages indexes if they don't exist.

cli/lib/search.go

@@ -69,9 +69,7 @@ func runSearchCommand(cmd *cobra.Command, args []string) {
 		os.Exit(errorcodes.ErrGeneric)
 	}
 
-	for _, err := range instance.Init(inst) {
-		feedback.Errorf(tr("Error initializing instance: %v"), err)
-	}
+	instance.Init(inst)
 
 	searchResp, err := lib.LibrarySearch(context.Background(), &rpc.LibrarySearchRequest{
 		Instance: inst,

docs/UPGRADING.md

@@ -2,6 +2,26 @@
 
 Here you can find a list of migration guides to handle breaking changes between releases of the CLI.
 
+## 0.29.0
+
+### Changes in golang functions `github.com/arduino/arduino-cli/cli/instance.Init` and `InitWithProfile`
+
+The following functions:
+
+```go
+func Init(instance *rpc.Instance) []error { }
+func InitWithProfile(instance *rpc.Instance, profileName string, sketchPath *paths.Path) (*rpc.Profile, []error) { }
+```
+
+no longer return the errors array:
+
+```go
+func Init(instance *rpc.Instance) { }
+func InitWithProfile(instance *rpc.Instance, profileName string, sketchPath *paths.Path) *rpc.Profile { }
+```
+
+The errors are automatically sent to output via `feedback` package, as for the other `Init*` functions.
+
 ## 0.28.0
 
 ### Breaking changes in libraries name handling