Renamed field for clarity

Author: cmaglie

commands/debug/debug_info.go

@@ -63,12 +63,12 @@ func IsDebugSupported(ctx context.Context, req *rpc.IsDebugSupportedRequest) (*r
 	}, pme, true)
 	var x *arduino.FailedDebugError
 	if errors.As(err, &x) {
-		return &rpc.IsDebugSupportedResponse{Supported: false}, nil
+		return &rpc.IsDebugSupportedResponse{DebuggingSupported: false}, nil
 	}
 	if err != nil {
 		return nil, err
 	}
-	return &rpc.IsDebugSupportedResponse{Supported: true}, nil
+	return &rpc.IsDebugSupportedResponse{DebuggingSupported: true}, nil
 }
 
 func getDebugProperties(req *rpc.GetDebugConfigRequest, pme *packagemanager.Explorer, skipSketchChecks bool) (*rpc.GetDebugConfigResponse, error) {

internal/cli/debug/debug_check.go

@@ -82,7 +82,7 @@ func (d *debugCheckResult) Data() interface{} {
 }
 
 func (d *debugCheckResult) String() string {
-	if d.Result.Supported {
+	if d.Result.DebuggingSupported {
 		return tr("The given board/programmer configuration supports debugging.")
 	}
 	return tr("The given board/programmer configuration does NOT support debugging.")

internal/cli/feedback/result/rpc.go

@@ -1059,11 +1059,11 @@ func NewCompileDiagnosticNote(cdn *rpc.CompileDiagnosticNote) *CompileDiagnostic
 }
 
 type IsDebugSupportedResponse struct {
-	Supported bool `json:"supported"`
+	DebuggingSupported bool `json:"debugging_supported"`
 }
 
 func NewIsDebugSupportedResponse(resp *rpc.IsDebugSupportedResponse) *IsDebugSupportedResponse {
 	return &IsDebugSupportedResponse{
-		Supported: resp.GetSupported(),
+		DebuggingSupported: resp.GetDebuggingSupported(),
 	}
 }

internal/integrationtest/debug/debug_test.go

@@ -345,13 +345,13 @@ func testDebugCheck(t *testing.T, env *integrationtest.Environment, cli *integra
 
 	out, _, err = cli.Run("debug", "check", "-b", "arduino:samd:mkr1000", "-P", "atmel_ice", "--format", "json")
 	require.NoError(t, err)
-	requirejson.Query(t, out, `.supported`, `true`)
+	requirejson.Query(t, out, `.debugging_supported`, `true`)
 
 	out, _, err = cli.Run("debug", "check", "-b", "arduino:avr:uno", "-P", "atmel_ice")
 	require.NoError(t, err)
 	require.Contains(t, string(out), "The given board/programmer configuration does NOT support debugging.")
 
 	out, _, err = cli.Run("debug", "check", "-b", "arduino:avr:uno", "-P", "atmel_ice", "--format", "json")
 	require.NoError(t, err)
-	requirejson.Query(t, out, `.supported`, `false`)
+	requirejson.Query(t, out, `.debugging_supported`, `false`)
 }

rpc/cc/arduino/cli/commands/v1/debug.pb.go

@@ -68,7 +68,7 @@ message IsDebugSupportedRequest {
 
 message IsDebugSupportedResponse {
   // True if debugging is supported
-  bool supported = 1;
+  bool debugging_supported = 1;
 }
 
 message GetDebugConfigRequest {