Added monitor dependencies support in package_manager

Author: cmaglie

arduino/cores/cores.go

@@ -293,6 +293,14 @@ func (release *PlatformRelease) RequiresToolRelease(toolRelease *ToolRelease) bo
 			return true
 		}
 	}
+	for _, monitor := range release.MonitorDependencies {
+		if monitor.Name == toolRelease.Tool.Name &&
+			monitor.Packager == toolRelease.Tool.Package.Name &&
+			// We always want the latest monitor version available
+			toolRelease.Version.Equal(toolRelease.Tool.LatestRelease().Version) {
+			return true
+		}
+	}
 	return false
 }
 

arduino/cores/packagemanager/package_manager.go

@@ -481,6 +481,17 @@ func (pm *PackageManager) FindToolsRequiredFromPlatformRelease(platform *cores.P
 		delete(foundTools, tool.Tool.Name)
 	}
 
+	platform.MonitorDependencies.Sort()
+	for _, monitorDep := range platform.MonitorDependencies {
+		pm.Log.WithField("monitor", monitorDep).Infof("Required monitor")
+		tool := pm.FindMonitorDependency(monitorDep)
+		if tool == nil {
+			return nil, fmt.Errorf(tr("monitor release not found: %s"), monitorDep)
+		}
+		requiredTools = append(requiredTools, tool)
+		delete(foundTools, tool.Tool.Name)
+	}
+
 	for _, toolRel := range foundTools {
 		requiredTools = append(requiredTools, toolRel)
 	}
@@ -563,3 +574,15 @@ func (pm *PackageManager) FindDiscoveryDependency(discovery *cores.DiscoveryDepe
 		return toolRelease.GetLatestInstalled()
 	}
 }
+
+// FindMonitorDependency returns the ToolRelease referenced by the MonitorDepenency or nil if
+// the referenced monitor doesn't exists.
+func (pm *PackageManager) FindMonitorDependency(discovery *cores.MonitorDependency) *cores.ToolRelease {
+	if pack := pm.Packages[discovery.Packager]; pack == nil {
+		return nil
+	} else if toolRelease := pack.Tools[discovery.Name]; toolRelease == nil {
+		return nil
+	} else {
+		return toolRelease.GetLatestInstalled()
+	}
+}

arduino/cores/packagemanager/package_manager_test.go

@@ -389,6 +389,24 @@ func TestFindToolsRequiredFromPlatformRelease(t *testing.T) {
 		toolRelease.InstallDir = fakePath
 	}
 
+	{
+		// ble-monitor tool
+		tool := pack.GetOrCreateTool("ble-monitor")
+		toolRelease := tool.GetOrCreateRelease(semver.ParseRelaxed("1.0.0"))
+		// We set this to fake the tool is installed
+		toolRelease.InstallDir = fakePath
+		tool.GetOrCreateRelease(semver.ParseRelaxed("0.1.0"))
+	}
+
+	{
+		// serial-monitor tool
+		tool := pack.GetOrCreateTool("serial-monitor")
+		tool.GetOrCreateRelease(semver.ParseRelaxed("1.0.0"))
+		toolRelease := tool.GetOrCreateRelease(semver.ParseRelaxed("0.1.0"))
+		// We set this to fake the tool is installed
+		toolRelease.InstallDir = fakePath
+	}
+
 	platform := pack.GetOrCreatePlatform("avr")
 	release := platform.GetOrCreateRelease(semver.MustParse("1.0.0"))
 	release.ToolDependencies = append(release.ToolDependencies, &cores.ToolDependency{
@@ -409,6 +427,14 @@ func TestFindToolsRequiredFromPlatformRelease(t *testing.T) {
 		Name:     "serial-discovery",
 		Packager: "arduino",
 	})
+	release.MonitorDependencies = append(release.MonitorDependencies, &cores.MonitorDependency{
+		Name:     "ble-monitor",
+		Packager: "arduino",
+	})
+	release.MonitorDependencies = append(release.MonitorDependencies, &cores.MonitorDependency{
+		Name:     "serial-monitor",
+		Packager: "arduino",
+	})
 	// We set this to fake the platform is installed
 	release.InstallDir = fakePath
 

arduino/cores/status.go

@@ -127,6 +127,33 @@ func (packages Packages) GetPlatformReleaseDiscoveryDependencies(release *Platfo
 	return res, nil
 }
 
+// GetPlatformReleaseMonitorDependencies returns the monitor releases needed by the specified PlatformRelease
+func (packages Packages) GetPlatformReleaseMonitorDependencies(release *PlatformRelease) ([]*ToolRelease, error) {
+	if release == nil {
+		return nil, fmt.Errorf(tr("release cannot be nil"))
+	}
+
+	res := []*ToolRelease{}
+	for _, monitor := range release.MonitorDependencies {
+		pkg, exists := packages[monitor.Packager]
+		if !exists {
+			return nil, fmt.Errorf(tr("package %s not found"), monitor.Packager)
+		}
+		tool, exists := pkg.Tools[monitor.Name]
+		if !exists {
+			return nil, fmt.Errorf(tr("tool %s not found"), monitor.Name)
+		}
+
+		// We always want to use the latest available release for monitors
+		latestRelease := tool.LatestRelease()
+		if latestRelease == nil {
+			return nil, fmt.Errorf(tr("can't find latest release of %s"), monitor.Name)
+		}
+		res = append(res, latestRelease)
+	}
+	return res, nil
+}
+
 // GetOrCreatePlatform returns the Platform object with the specified architecture
 // or creates a new one if not found
 func (targetPackage *Package) GetOrCreatePlatform(architecture string) *Platform {

i18n/data/en.po

@@ -2399,6 +2399,7 @@ msgid "calling %[1]s: %[2]w"
 msgstr "calling %[1]s: %[2]w"
 
 #: arduino/cores/status.go:123
+#: arduino/cores/status.go:150
 msgid "can't find latest release of %s"
 msgstr "can't find latest release of %s"
 
@@ -2912,6 +2913,10 @@ msgstr "missing platform %[1]s:%[2]s referenced by board %[3]s"
 msgid "missing platform release %[1]s:%[2]s referenced by board %[3]s"
 msgstr "missing platform release %[1]s:%[2]s referenced by board %[3]s"
 
+#: arduino/cores/packagemanager/package_manager.go:489
+msgid "monitor release not found: %s"
+msgstr "monitor release not found: %s"
+
 #: arduino/libraries/librariesmanager/install.go:179
 #: arduino/resources/install.go:94
 msgid "moving extracted archive to destination dir: %s"
@@ -2981,14 +2986,15 @@ msgstr "opening target file: %s"
 #: arduino/cores/packagemanager/download.go:73
 #: arduino/cores/status.go:88
 #: arduino/cores/status.go:113
+#: arduino/cores/status.go:140
 msgid "package %s not found"
 msgstr "package %s not found"
 
 #: arduino/cores/packagemanager/package_manager.go:259
 msgid "package '%s' not found"
 msgstr "package '%s' not found"
 
-#: arduino/cores/status.go:167
+#: arduino/cores/status.go:194
 msgid "package not found"
 msgstr "package not found"
 
@@ -3117,10 +3123,11 @@ msgstr "release %[1]s not found for tool %[2]s"
 
 #: arduino/cores/status.go:82
 #: arduino/cores/status.go:106
+#: arduino/cores/status.go:133
 msgid "release cannot be nil"
 msgstr "release cannot be nil"
 
-#: arduino/cores/status.go:183
+#: arduino/cores/status.go:210
 msgid "release not found"
 msgstr "release not found"
 
@@ -3240,6 +3247,7 @@ msgstr "tool %s is not managed by package manager"
 
 #: arduino/cores/status.go:92
 #: arduino/cores/status.go:117
+#: arduino/cores/status.go:144
 msgid "tool %s not found"
 msgstr "tool %s not found"
 
@@ -3251,7 +3259,7 @@ msgstr "tool '%[1]s' not found in package '%[2]s'"
 msgid "tool not available for your OS"
 msgstr "tool not available for your OS"
 
-#: arduino/cores/status.go:171
+#: arduino/cores/status.go:198
 msgid "tool not found"
 msgstr "tool not found"
 
@@ -3260,7 +3268,7 @@ msgid "tool not installed"
 msgstr "tool not installed"
 
 #: arduino/cores/packagemanager/package_manager.go:467
-#: arduino/cores/packagemanager/package_manager.go:533
+#: arduino/cores/packagemanager/package_manager.go:544
 msgid "tool release not found: %s"
 msgstr "tool release not found: %s"