add flag to allow board options to be specified seperately from fqbn

Author: umbynos

cli/arguments/fqbn.go

@@ -21,7 +21,9 @@ import "github.com/spf13/cobra"
 // This is useful so all flags used by commands that need
 // this information are consistent with each other.
 type Fqbn struct {
-	fqbn string
+	fqbn         string
+	boardOptions []string // List of boards specific options separated by commas. Or can be used multiple times for multiple options.
+
 }
 
 // AddToCommand adds the flags used to set fqbn to the specified Command
@@ -30,6 +32,8 @@ func (f *Fqbn) AddToCommand(cmd *cobra.Command) {
 	cmd.RegisterFlagCompletionFunc("fqbn", func(cmd *cobra.Command, args []string, toComplete string) ([]string, cobra.ShellCompDirective) {
 		return GetInstalledBoards(), cobra.ShellCompDirectiveDefault
 	})
+	cmd.Flags().StringSliceVar(&f.boardOptions, "board-options", []string{},
+		tr("List of board options separated by commas. Or can be used multiple times for multiple options."))
 }
 
 // String returns the fqbn
@@ -41,3 +45,7 @@ func (f *Fqbn) String() string {
 func (f *Fqbn) Set(fqbn string) {
 	f.fqbn = fqbn
 }
+
+func (f *Fqbn) GetOptions() []string {
+	return f.boardOptions
+}

cli/compile/compile.go

@@ -160,6 +160,14 @@ func runCompileCommand(cmd *cobra.Command, args []string) {
 	}
 
 	detectedFqbn := fqbn.String()
+
+	// If boardOptions are passed with the "--board-options" flags then add them along with the fqbn
+	// This way it's possible to use either the legacy way (appending board options directly to the fqbn),
+	// or the new and more elegant way (using "--board-options"), even using multiple "--board-options" works.
+	if detectedFqbn != "" && len(fqbn.GetOptions()) != 0 {
+		detectedFqbn += ":" + strings.Join(fqbn.GetOptions(), ",")
+	}
+
 	var sk *sketch.Sketch
 	var discoveryPort *discovery.Port
 	// If the user didn't provide an FQBN it might either mean