Platform's installed.json is now loaded if found

Author: silvanocerza

arduino/cores/packagemanager/loader.go

@@ -265,10 +265,20 @@ func (pm *PackageManager) loadPlatformRelease(platform *cores.PlatformRelease, p
 	platform.InstallDir = path
 
 	// Some useful paths
+	installedJSONPath := path.Join("installed.json")
 	platformTxtPath := path.Join("platform.txt")
 	platformTxtLocalPath := path.Join("platform.local.txt")
 	programmersTxtPath := path.Join("programmers.txt")
 
+	// If the installed.json file is found load it, this is done to handle the
+	// case in which the platform's index and its url have been deleted locally,
+	// if we don't load it some information about the platform is lost
+	if installedJSONPath.Exist() {
+		if _, err := pm.LoadPackageIndexFromFile(installedJSONPath); err != nil {
+			return fmt.Errorf("loading %s: %s", installedJSONPath, err)
+		}
+	}
+
 	// Create platform properties
 	platform.Properties = platform.Properties.Clone() // TODO: why CLONE?
 	if p, err := properties.SafeLoad(platformTxtPath.String()); err == nil {

test/test_core.py

@@ -64,17 +64,24 @@ def test_core_search_no_args(run_command, httpserver):
     result = run_command("core search")
     assert result.ok
     num_platforms = 0
+    found = False
     for l in result.stdout.splitlines()[1:]:  # ignore the header on first line
         if l:  # ignore empty lines
-            assert not l.startswith("test:x86")
+            if l.startswith("test:x86"):
+                found = True
             num_platforms += 1
 
     # same thing in JSON format, also check the number of platforms found is the same
     result = run_command("core search --format json")
     assert result.ok
     platforms = json.loads(result.stdout)
+    found = False
+    platforms = json.loads(result.stdout)
     for elem in platforms:
-        assert elem.get("Name") != "test_core"
+        if elem.get("Name") == "test_core":
+            found = True
+            break
+    assert found
     assert len(platforms) == num_platforms
 
     # list all with additional urls, check the test core is there