Merged downloadPlatform with the proper packagamanger method

Author: cmaglie

commands/core/download.go

@@ -19,9 +19,7 @@ import (
 	"context"
 
 	"github.com/arduino/arduino-cli/arduino"
-	"github.com/arduino/arduino-cli/arduino/cores"
 	"github.com/arduino/arduino-cli/arduino/cores/packagemanager"
-	"github.com/arduino/arduino-cli/arduino/httpclient"
 	"github.com/arduino/arduino-cli/commands"
 	"github.com/arduino/arduino-cli/i18n"
 	rpc "github.com/arduino/arduino-cli/rpc/cc/arduino/cli/commands/v1"
@@ -51,7 +49,7 @@ func PlatformDownload(ctx context.Context, req *rpc.PlatformDownloadRequest, dow
 		return nil, &arduino.PlatformNotFoundError{Platform: ref.String(), Cause: err}
 	}
 
-	if err := downloadPlatform(pm, platform, downloadCB); err != nil {
+	if err := pm.DownloadPlatformRelease(platform, nil, downloadCB); err != nil {
 		return nil, err
 	}
 
@@ -63,12 +61,3 @@ func PlatformDownload(ctx context.Context, req *rpc.PlatformDownloadRequest, dow
 
 	return &rpc.PlatformDownloadResponse{}, nil
 }
-
-func downloadPlatform(pm *packagemanager.PackageManager, platformRelease *cores.PlatformRelease, downloadCB rpc.DownloadProgressCB) error {
-	// Download platform
-	config, err := httpclient.GetDownloaderConfig()
-	if err != nil {
-		return &arduino.FailedDownloadError{Message: tr("Error downloading platform %s", platformRelease), Cause: err}
-	}
-	return pm.DownloadPlatformRelease(platformRelease, config, downloadCB)
-}

commands/core/install.go

@@ -99,7 +99,7 @@ func installPlatform(pm *packagemanager.PackageManager,
 			return err
 		}
 	}
-	if err := downloadPlatform(pm, platformRelease, downloadCB); err != nil {
+	if err := pm.DownloadPlatformRelease(platformRelease, nil, downloadCB); err != nil {
 		return err
 	}
 	taskCB(&rpc.TaskProgress{Completed: true})