ported SketchThatIncludesArduinoH from legacy into integration test

Author: alessio-perugini

internal/integrationtest/compile_4/compile_test.go

@@ -101,6 +101,7 @@ func TestCompileOfProblematicSketches(t *testing.T) {
 		{"SketchThatChecksIfSPIHasTransactions", tryBuildAvrLeonardo},
 		{"SketchWithDependendLibraries", tryBuildAvrLeonardo},
 		{"SketchWithFunctionPointer", tryBuildAvrLeonardo},
+		{"SketchThatIncludesArduinoH", testBuilderSketchThatIncludesArduinoH},
 		{"USBHostExample", testBuilderUSBHostExample},
 		{"SketchWithConflictingLibraries", testBuilderSketchWithConflictingLibraries},
 		{"SketchLibraryProvidesAllIncludes", testBuilderSketchLibraryProvidesAllIncludes},
@@ -613,6 +614,21 @@ func tryBuildAvrLeonardo(t *testing.T, env *integrationtest.Environment, cli *in
 	require.NoError(t, err)
 }
 
+func testBuilderSketchThatIncludesArduinoH(t *testing.T, env *integrationtest.Environment, cli *integrationtest.ArduinoCLI) {
+	t.Run("Build", func(t *testing.T) {
+		// Build
+		_, err := tryBuild(t, env, cli, "arduino:avr:leonardo")
+		require.NoError(t, err)
+	})
+
+	t.Run("Preprocess", func(t *testing.T) {
+		// Preprocess
+		sketchPath, preprocessedSketch, err := tryPreprocess(t, env, cli, "arduino:avr:leonardo")
+		require.NoError(t, err)
+		comparePreprocessGoldenFile(t, sketchPath, preprocessedSketch)
+	})
+}
+
 type builderOutput struct {
 	CompilerOut   string `json:"compiler_out"`
 	CompilerErr   string `json:"compiler_err"`

…ino_h/sketch_that_includes_arduino_h.ino …sArduinoH/SketchThatIncludesArduinoH.inolegacy/builder/test/sketch_that_includes_arduino_h/sketch_that_includes_arduino_h.ino renamed to internal/integrationtest/compile_4/testdata/SketchThatIncludesArduinoH/SketchThatIncludesArduinoH.ino legacy/builder/test/sketch_that_includes_arduino_h/sketch_that_includes_arduino_h.ino renamed to internal/integrationtest/compile_4/testdata/SketchThatIncludesArduinoH/SketchThatIncludesArduinoH.ino

@@ -0,0 +1,21 @@
+#line 1 {{QuoteCppString .sketchMainFile}}
+// Arduino.h should not be automatically included by the Arduino
+// preprocessor before the explicit include line in this sketch.
+
+#if defined(HIGH)
+#error Arduino.h seems to be automatically included
+#endif
+
+   #    include		<Arduino.h>
+
+#line 10 {{QuoteCppString .sketchMainFile}}
+void setup();
+#line 13 {{QuoteCppString .sketchMainFile}}
+void loop();
+#line 10 {{QuoteCppString .sketchMainFile}}
+void setup() {
+}
+
+void loop() {
+}
+

internal/integrationtest/compile_4/testdata/SketchThatIncludesArduinoH/SketchThatIncludesArduinoH.preprocessed.txt

@@ -28,9 +28,6 @@ import (
 )
 
 // TODO add them in the compile_4
-func TestTryBuild033(t *testing.T) {
-	tryBuild(t, paths.New("sketch_that_includes_arduino_h", "sketch_that_includes_arduino_h.ino"))
-}
 
 func TestTryBuild034(t *testing.T) {
 	tryBuild(t, paths.New("sketch_with_static_asserts", "sketch_with_static_asserts.ino"))