Created configuration defaults for build_cache.path setting

Author: cmaglie

commands/service_compile.go

@@ -196,10 +196,8 @@ func (s *arduinoCoreServerImpl) Compile(req *rpc.CompileRequest, stream rpc.Ardu
 				return &cmderrors.PermissionDeniedError{Message: i18n.Tr("Cannot create build cache directory"), Cause: err}
 			}
 			buildCachePath = p
-		} else if p, ok := s.settings.GetBuildCachePath(); ok {
-			buildCachePath = p
 		} else {
-			buildCachePath = paths.TempDir().Join("arduino")
+			buildCachePath = s.settings.GetBuildCachePath()
 		}
 		if err := buildCachePath.MkdirAll(); err != nil {
 			return &cmderrors.PermissionDeniedError{Message: i18n.Tr("Cannot create build cache directory"), Cause: err}

internal/cli/configuration/build_cache.go

@@ -38,12 +38,11 @@ func (s *Settings) GetBuildCacheTTL() time.Duration {
 }
 
 // GetBuildCachePath returns the path to the build cache.
-func (s *Settings) GetBuildCachePath() (*paths.Path, bool) {
-	p, ok, _ := s.GetStringOk("build_cache.path")
-	if !ok {
-		return nil, false
+func (s *Settings) GetBuildCachePath() *paths.Path {
+	if p, ok, _ := s.GetStringOk("build_cache.path"); ok {
+		return paths.New(p)
 	}
-	return paths.New(p), true
+	return paths.New(s.Defaults.GetString("build_cache.path"))
 }
 
 // GetBuildCacheExtraPaths returns the extra paths to the build cache.

internal/cli/configuration/configuration.go

@@ -101,6 +101,11 @@ func getDefaultUserDir() string {
 	}
 }
 
+// getDefaultBuildCacheDir returns the full path to the default build cache folder
+func getDefaultBuildCacheDir() string {
+	return paths.TempDir().Join("arduino").String()
+}
+
 // FindConfigFlagsInArgsOrFallbackOnEnv returns the config file path using the
 // argument '--config-file' (if specified), if empty looks for the ARDUINO_CONFIG_FILE env,
 // or looking in the current working dir

internal/cli/configuration/defaults.go

@@ -52,7 +52,7 @@ func SetDefaults(settings *Settings) {
 	setDefaultValueAndKeyTypeSchema("sketch.always_export_binaries", false)
 	setDefaultValueAndKeyTypeSchema("build_cache.ttl", (time.Hour * 24 * 30).String())
 	setDefaultValueAndKeyTypeSchema("build_cache.compilations_before_purge", uint(10))
-	setKeyTypeSchema("build_cache.path", "")
+	setDefaultValueAndKeyTypeSchema("build_cache.path", getDefaultBuildCacheDir())
 	setKeyTypeSchema("build_cache.extra_paths", []string{})
 
 	// daemon settings