fix regression which skipped mannually instaled core in core list

Author: alessio-perugini

commands/core/search.go

@@ -44,10 +44,12 @@ func PlatformSearch(req *rpc.PlatformSearchRequest) (*rpc.PlatformSearchResponse
 		searchArgs := utils.SearchTermsFromQueryString(req.SearchArgs)
 		for _, targetPackage := range pme.GetPackages() {
 			for _, platform := range targetPackage.Platforms {
+				if platform == nil {
+					continue
+				}
 				// Users can install platforms manually in the Sketchbook hardware folder,
-				// the core search command must operate only on platforms installed through
-				// the PlatformManager, thus we skip the manually installed ones.
-				if platform == nil || platform.ManuallyInstalled {
+				// if not explictily requested we skip them.
+				if !req.ManuallyInstalled && platform.ManuallyInstalled {
 					continue
 				}
 

internal/cli/core/list.go

@@ -62,8 +62,9 @@ func List(inst *rpc.Instance, all bool, updatableOnly bool) {
 // GetList returns a list of installed platforms.
 func GetList(inst *rpc.Instance, all bool, updatableOnly bool) []*rpc.PlatformSummary {
 	platforms, err := core.PlatformSearch(&rpc.PlatformSearchRequest{
-		Instance:    inst,
-		AllVersions: true,
+		Instance:          inst,
+		AllVersions:       true,
+		ManuallyInstalled: true,
 	})
 	if err != nil {
 		feedback.Fatal(tr("Error listing platforms: %v", err), feedback.ErrGeneric)

rpc/cc/arduino/cli/commands/v1/core.pb.go

@@ -118,6 +118,9 @@ message PlatformSearchRequest {
   // Whether to show all available versions. `false` causes only the newest
   // versions of the cores to be listed in the search results.
   bool all_versions = 3;
+  // Whether to show manually installed platforms. `false` causes to skip
+  // manually installed platforms.
+  bool manually_installed = 4;
 }
 
 message PlatformSearchResponse {