fixes after code review

Author: fstasi

arduino-ide-extension/src/browser/arduino-frontend-contribution.tsx

@@ -418,6 +418,15 @@ export class ArduinoFrontendContribution implements FrontendApplicationContribut
                 },
                 description: 'Background color of the toolbar items when hovering over them. Such as Upload, Verify, etc.'
             },
+            {
+              id: 'arduino.toolbar.toggleBackground',
+              defaults: {
+                  dark: 'editor.selectionBackground',
+                  light: 'editor.selectionBackground',
+                  hc: 'activityBar.inactiveForeground'
+              },
+              description: 'Toggle color of the toolbar items when they are currently toggled (the command is in progress)'
+            },
             {
                 id: 'arduino.output.foreground',
                 defaults: {

arduino-ide-extension/src/browser/contributions/upload-sketch.ts

@@ -22,7 +22,7 @@ export class UploadSketch extends SketchContribution {
     @inject(BoardsServiceProvider)
     protected readonly boardsServiceClientImpl: BoardsServiceProvider;
 
-    uploadInProgress = false;
+    protected uploadInProgress = false;
 
     registerCommands(registry: CommandRegistry): void {
         registry.registerCommand(UploadSketch.Commands.UPLOAD_SKETCH, {

arduino-ide-extension/src/browser/contributions/verify-sketch.ts

@@ -18,7 +18,7 @@ export class VerifySketch extends SketchContribution {
     @inject(BoardsServiceProvider)
     protected readonly boardsServiceClientImpl: BoardsServiceProvider;
 
-    verifyInProgress = false;
+    protected verifyInProgress = false;
 
     registerCommands(registry: CommandRegistry): void {
         registry.registerCommand(VerifySketch.Commands.VERIFY_SKETCH, {

arduino-ide-extension/src/browser/style/main.css

@@ -16,7 +16,7 @@
 }
 
 .p-TabBar-toolbar .item.arduino-tool-item:hover > div {
-    background: white;
+    background: var(--theia-arduino-toolbar-hoverBackground);
 }
 
 .arduino-verify-sketch--toolbar,
@@ -30,7 +30,7 @@
 }
 
 .item.arduino-tool-item.toggled .arduino-verify-sketch--toolbar {
-  background-color: rgb(255,204,0) !important;
+  background-color: var(--theia-arduino-toolbar-toggleBackground) !important;
 }
 
 .arduino-tool-icon {