Remove gRPC error code from error notifications

Author: silvanocerza

arduino-ide-extension/src/browser/contributions/burn-bootloader.ts

@@ -79,7 +79,13 @@ export class BurnBootloader extends SketchContribution {
         }
       );
     } catch (e) {
-      this.messageService.error(e.toString());
+      let errorMessage = "";
+      if (typeof e === "string") {
+        errorMessage = e;
+      } else {
+        errorMessage = e.toString();
+      }
+      this.messageService.error(errorMessage);
     } finally {
       if (this.serialConnection.isSerialOpen()) {
         await this.serialConnection.connect();

arduino-ide-extension/src/browser/contributions/upload-sketch.ts

@@ -277,7 +277,13 @@ export class UploadSketch extends SketchContribution {
         { timeout: 3000 }
       );
     } catch (e) {
-      this.messageService.error(e.toString());
+      let errorMessage = "";
+      if (typeof e === "string") {
+        errorMessage = e;
+      } else {
+        errorMessage = e.toString();
+      }
+      this.messageService.error(errorMessage);
     } finally {
       this.uploadInProgress = false;
       this.onDidChangeEmitter.fire();

arduino-ide-extension/src/browser/contributions/verify-sketch.ts

@@ -127,7 +127,13 @@ export class VerifySketch extends SketchContribution {
         { timeout: 3000 }
       );
     } catch (e) {
-      this.messageService.error(e.toString());
+      let errorMessage = "";
+      if (typeof e === "string") {
+        errorMessage = e;
+      } else {
+        errorMessage = e.toString();
+      }
+      this.messageService.error(errorMessage);
     } finally {
       this.verifyInProgress = false;
       this.onDidChangeEmitter.fire();

arduino-ide-extension/src/node/core-service-impl.ts

@@ -85,11 +85,12 @@ export class CoreServiceImpl extends CoreClientAware implements CoreService {
         chunk: '\n--------------------------\nCompilation complete.\n',
       });
     } catch (e) {
+      const errorMessage = `Compilation error: ${e.details}`
       this.responseService.appendToOutput({
-        chunk: `Compilation error: ${e.details}\n`,
+        chunk: `${errorMessage}}\n`,
         severity: 'error',
       });
-      throw e;
+      throw new Error(errorMessage);
     }
   }
 
@@ -180,11 +181,12 @@ export class CoreServiceImpl extends CoreClientAware implements CoreService {
           ' complete.\n',
       });
     } catch (e) {
+      const errorMessage = `${firstToUpperCase(task)} error: ${e.details}`;
       this.responseService.appendToOutput({
-        chunk: `${firstToUpperCase(task)} error: ${e.details}\n`,
+        chunk: `${errorMessage}\n`,
         severity: 'error',
       });
-      throw e;
+      throw new Error(errorMessage);
     } finally {
       this.uploading = false;
     }
@@ -227,11 +229,12 @@ export class CoreServiceImpl extends CoreClientAware implements CoreService {
         result.on('end', () => resolve());
       });
     } catch (e) {
+      const errorMessage = `Error while burning the bootloader: ${e.details}`;
       this.responseService.appendToOutput({
-        chunk: `Error while burning the bootloader: ${e.details}\n`,
+        chunk: `${errorMessage}\n`,
         severity: 'error',
       });
-      throw e;
+      throw new Error(errorMessage);
     }
   }