fix: renamed application error factory method

Signed-off-by: Akos Kitta <a.kitta@arduino.cc>

Author: Akos Kitta

arduino-ide-extension/src/common/protocol/core-service.ts

@@ -73,12 +73,12 @@ export namespace CoreError {
     UploadUsingProgrammer: 4003,
     BurnBootloader: 4004,
   };
-  export const VerifyFailed = create(Codes.Verify);
-  export const UploadFailed = create(Codes.Upload);
-  export const UploadUsingProgrammerFailed = create(
+  export const VerifyFailed = declareCoreError(Codes.Verify);
+  export const UploadFailed = declareCoreError(Codes.Upload);
+  export const UploadUsingProgrammerFailed = declareCoreError(
     Codes.UploadUsingProgrammer
   );
-  export const BurnBootloaderFailed = create(Codes.BurnBootloader);
+  export const BurnBootloaderFailed = declareCoreError(Codes.BurnBootloader);
   export function is(
     error: unknown
   ): error is ApplicationError<number, ErrorLocation[]> {
@@ -88,7 +88,7 @@ export namespace CoreError {
       Object.values(Codes).includes(error.code)
     );
   }
-  function create(
+  function declareCoreError(
     code: number
   ): ApplicationError.Constructor<number, ErrorLocation[]> {
     return ApplicationError.declare(

arduino-ide-extension/src/common/protocol/monitor-service.ts

@@ -79,16 +79,16 @@ export const MonitorErrorCodes = {
   MissingConfiguration: 6004,
 } as const;
 
-export const ConnectionFailedError = createMonitorError(
+export const ConnectionFailedError = declareMonitorError(
   MonitorErrorCodes.ConnectionFailed
 );
-export const NotConnectedError = createMonitorError(
+export const NotConnectedError = declareMonitorError(
   MonitorErrorCodes.NotConnected
 );
-export const AlreadyConnectedError = createMonitorError(
+export const AlreadyConnectedError = declareMonitorError(
   MonitorErrorCodes.AlreadyConnected
 );
-export const MissingConfigurationError = createMonitorError(
+export const MissingConfigurationError = declareMonitorError(
   MonitorErrorCodes.MissingConfiguration
 );
 
@@ -167,7 +167,7 @@ interface PortDescriptor {
   readonly protocol: string;
   readonly address: string;
 }
-function createMonitorError(
+function declareMonitorError(
   code: number
 ): ApplicationError.Constructor<number, PortDescriptor> {
   return ApplicationError.declare(