allow to specify version with v semantic like v1.0.0

This will be a breaking change. Internally we will make no distinction between
tags starting with `v` prefix and ones that doesn't have it. This means
that for version `0.x` for the cli, because we changed the tag naming in
the latest releases, the `0.x` version will be expaned to `0.36.rc2`
instead of `0.34.2`.

Author: alessio-perugini

__tests__/main.test.ts

@@ -84,9 +84,50 @@ describe("installer tests", () => {
       }
     }, 20000);
 
-    it("Gets latest version of Task using 0.x and no matching version is installed", async () => {
+    it("Gets the latest version of Arduino CLI v1.0.0 using 1.0.0 with no `v` prefix", async () => {
+      await installer.getArduinoCli("1.0.0");
+      const bindir = path.join(toolDir, "arduino-cli", "1.0.0", os.arch());
+
+      expect(fs.existsSync(`${bindir}.complete`)).toBe(true);
+      if (IS_WINDOWS) {
+        expect(fs.existsSync(path.join(bindir, "arduino-cli.exe"))).toBe(true);
+      } else {
+        expect(fs.existsSync(path.join(bindir, "arduino-cli"))).toBe(true);
+      }
+    }, 20000);
+
+    it("Gets the latest version of Arduino CLI v1.0.0 using the `v` prefix (v1.0.0)", async () => {
+      await installer.getArduinoCli("v1.0.0");
+      const bindir = path.join(toolDir, "arduino-cli", "1.0.0", os.arch());
+
+      expect(fs.existsSync(`${bindir}.complete`)).toBe(true);
+      if (IS_WINDOWS) {
+        expect(fs.existsSync(path.join(bindir, "arduino-cli.exe"))).toBe(true);
+      } else {
+        expect(fs.existsSync(path.join(bindir, "arduino-cli"))).toBe(true);
+      }
+    }, 20000);
+
+    it("Gets the latest version of Arduino CLI using the v1.x", async () => {
+      await installer.getArduinoCli("v1.x");
+      const bindir = path.join(toolDir, "arduino-cli", "1.0.1", os.arch());
+
+      expect(fs.existsSync(`${bindir}.complete`)).toBe(true);
+      if (IS_WINDOWS) {
+        expect(fs.existsSync(path.join(bindir, "arduino-cli.exe"))).toBe(true);
+      } else {
+        expect(fs.existsSync(path.join(bindir, "arduino-cli"))).toBe(true);
+      }
+    }, 20000);
+
+    it("Gets latest version of Arduino CLI using 0.x and no matching version is installed", async () => {
       await installer.getArduinoCli("0.x");
-      const bindir = path.join(toolDir, "arduino-cli", "0.34.2", os.arch());
+      const bindir = path.join(
+        toolDir,
+        "arduino-cli",
+        "0.36.0-rc.2",
+        os.arch(),
+      );
 
       expect(fs.existsSync(`${bindir}.complete`)).toBe(true);
       if (IS_WINDOWS) {

src/installer.ts

@@ -117,6 +117,11 @@ function getFileName(version: string): string {
       break;
   }
 
+  // Newer versions of the cli are tagged with the `v` prefix, but the artifacts
+  // doesn't containt that prefix, se we normalize the version.
+  if (version.startsWith("v")) {
+    version = version.substring(1);
+  }
   return util.format("arduino-cli_%s_%s_%s.%s", version, platform, arch, ext);
 }
 
@@ -141,13 +146,25 @@ async function fetchVersions(): Promise<string[]> {
 
 // Compute an actual version starting from the `version` configuration param.
 async function computeVersion(version: string): Promise<string> {
+  // remove the v prefix. This is done for backwards compatibility reasion.
+  // Newer releases of the cli are tagged with the v prefix, but not the older
+  // ones.
+  if (version.startsWith("v")) {
+    version = version.substring(1);
+  }
+
   // strip trailing .x chars
   if (version.endsWith(".x")) {
     version = version.slice(0, version.length - 2);
   }
 
   const allVersions = await fetchVersions();
-  const possibleVersions = allVersions.filter((v) => v.startsWith(version));
+  const possibleVersions = allVersions.filter(function (v) {
+    if (v.startsWith("v")) {
+      return v.startsWith("v" + version);
+    }
+    return v.startsWith(version);
+  });
 
   const versionMap = new Map();
   possibleVersions.forEach((v) => versionMap.set(normalizeVersion(v), v));