From 8b3815dfbe97db82c3a53388e83a9335d52be240 Mon Sep 17 00:00:00 2001 From: lfbrehm <97600985+lfbrehm@users.noreply.github.com> Date: Mon, 26 Jun 2023 15:34:30 +0200 Subject: [PATCH 1/2] fix: GetObjectsAsListV2Response should return ObjectWithURL --- aruna/api/storage/services/v1/object_service.proto | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/aruna/api/storage/services/v1/object_service.proto b/aruna/api/storage/services/v1/object_service.proto index 8764b8c5..36de956f 100644 --- a/aruna/api/storage/services/v1/object_service.proto +++ b/aruna/api/storage/services/v1/object_service.proto @@ -828,7 +828,7 @@ message GetObjectsAsListV2Response { bool is_truncated = 2; uint32 max_keys = 4; uint32 key_count = 5; - repeated storage.models.v1.Object contents = 6; + repeated ObjectWithURL contents = 6; repeated CommonPrefix prefixes = 7; optional string next_continuation_token = 8; } From 90d3a25286bec2a88649167e7df2d911e30bb592 Mon Sep 17 00:00:00 2001 From: lfbrehm <97600985+lfbrehm@users.noreply.github.com> Date: Mon, 26 Jun 2023 15:54:06 +0200 Subject: [PATCH 2/2] fix: Added comments --- aruna/api/storage/services/v1/object_service.proto | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/aruna/api/storage/services/v1/object_service.proto b/aruna/api/storage/services/v1/object_service.proto index 36de956f..430ad4b9 100644 --- a/aruna/api/storage/services/v1/object_service.proto +++ b/aruna/api/storage/services/v1/object_service.proto @@ -358,7 +358,7 @@ service ObjectService { // // Status: ALPHA // - // Gets a list of objects represented similar to a S3 ListObjectsV2 request + // Gets a list of ObjectWithURLs represented similar to a S3 ListObjectsV2 request // !! Paths are collection specific !! rpc GetObjectsAsListV2(GetObjectsAsListV2Request) returns (GetObjectsAsListV2Response) { option (google.api.http) = { @@ -828,6 +828,7 @@ message GetObjectsAsListV2Response { bool is_truncated = 2; uint32 max_keys = 4; uint32 key_count = 5; + // Does not contain URLs, only paths repeated ObjectWithURL contents = 6; repeated CommonPrefix prefixes = 7; optional string next_continuation_token = 8;