From abd91bbc96cdd7d5a57e2927076f57911534997d Mon Sep 17 00:00:00 2001
From: St4NNi <sb@pus.de>
Date: Tue, 18 Jul 2023 11:54:40 +0200
Subject: [PATCH] feat: Update InternalRelation variants to be more explizit
 for custom / non-custom types

---
 aruna/api/storage/models/v2/models.proto | 18 +++++++++---------
 1 file changed, 9 insertions(+), 9 deletions(-)

diff --git a/aruna/api/storage/models/v2/models.proto b/aruna/api/storage/models/v2/models.proto
index 1c4d345b..dcc0b0a2 100644
--- a/aruna/api/storage/models/v2/models.proto
+++ b/aruna/api/storage/models/v2/models.proto
@@ -52,6 +52,7 @@ enum ExternalRelationVariant {
   EXTERNAL_RELATION_VARIANT_UNSPECIFIED = 0;
   EXTERNAL_RELATION_VARIANT_URL = 1;
   EXTERNAL_RELATION_VARIANT_IDENTIFIER = 2;
+  EXTERNAL_RELATION_VARIANT_CUSTOM = 3;
 }
 
 // InternalRelations
@@ -59,9 +60,10 @@ enum InternalRelationVariant {
   INTERNAL_RELATION_VARIANT_UNSPECIFIED = 0;
   INTERNAL_RELATION_VARIANT_BELONGS_TO = 1;
   INTERNAL_RELATION_VARIANT_ORIGIN = 2;
-  INTERNAL_RELATION_VARIANT_DERIVED = 3;
+  INTERNAL_RELATION_VARIANT_VERSION = 3;
   INTERNAL_RELATION_VARIANT_METADATA = 4;
   INTERNAL_RELATION_VARIANT_POLICY = 5;
+  INTERNAL_RELATION_VARIANT_CUSTOM = 6;
 }
 
 // internal object relation type (direction)
@@ -192,19 +194,17 @@ message Relation {
 
 message ExternalRelation {
   string identifier = 1;
-  oneof variant {
-    ExternalRelationVariant defined_variant = 2;
-    string custom_variant = 3;
-  }
+  ExternalRelationVariant defined_variant = 2;
+  // Will only be filled if defined_variant == CUSTOM
+  optional string custom_variant = 3;
 }
 
 message InternalRelation {
   string resource_id = 1;
   ResourceVariant resource_variant = 2;
-  oneof variant {
-    InternalRelationVariant defined_variant = 3;
-    string custom_variant = 4;
-  }
+  InternalRelationVariant defined_variant = 3;
+  // Will only be filled if defined_variant == CUSTOM
+  optional string custom_variant = 4;
   RelationDirection direction = 5;
 }