Conversation
ghost
added
the
Member
Author
|
There is no funky "User has read an accepted it and thus hides the message"-behavior implemented. This would be more complex and raise the question about lifetime of the announcement. |
ruKurz
reviewed
Sep 28, 2017
ruKurz
left a comment
ruKurz
left a comment
There was a problem hiding this comment.
looks good to me. Only thing to mention is that fixed sizes in px should be prevented if possible or set to a global constant.
| box-shadow: | ||
| 0 1px 1px 0 rgba(0, 0, 0, 0.2), | ||
| 0 2px 10px 0 rgba(0, 0, 0, 0.16); | ||
| border-radius: 4px; |
There was a problem hiding this comment.
Is there a constant available for the border-radius?
|
|
||
| #login-global-announcement { | ||
| width: 100%; | ||
| max-width: 520px; |
|
|
||
| #login-card { | ||
| width: 100%; | ||
| max-width: 520px; |
ruKurz
approved these changes
Sep 28, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a configurable, highlighted message to the Login- and Home-Screen.
Closes #63
A downport to RC core is pending. I'll create a new issue for that on RC