fix: missing code_challenge and state mismatch #465
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nt code_challenge missing in authorize query
jals1212
changed the title
Owner
|
Why not reading the |
Author
You're right that's less invasive and leaner, I'll make the change. Thanks. |
…e functions, and get the code directly from event query
Author
|
Ready @atinux |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FIX: Update handlePkceVerifier to prevent missing code_challenge, and prevent state mismatch.
Description:
If something goes wrong in authorize endpoint (some extra authorizationParams missing or incorrect) and you try again to authorize you end up with a missing code_challenge in the query, same for state (state mismatch).
Fix:
Read the code (from event query) inside the handlePkceVerifier and handleState functions, if the code is present then is not necessary to regenerate the code_challenge or the state.