Skip to content

fix: missing code_challenge and state mismatch #465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jals1212 wants to merge 6 commits into
base: main
Choose a base branch
from
Open

fix: missing code_challenge and state mismatch #465

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
4492691
fix: update handlePkceVerifier to accept onlyConsume option for preve…
jals1212 Nov 6, 2025
bf546d8
fix: refactor handlePkceVerifier and handleState to accept onlyConsum…
jals1212 Nov 25, 2025
81ac65a
Merge branch 'atinux:main' into fix-oauth-pkce-mismatch
jals1212 Nov 25, 2025
67ab8fb
fix: remove onlyConsume option from handlePkceVerifier and handleStat…
jals1212 Dec 2, 2025
26aa930
fix: add verifier and state checks in handlePkceVerifier and handleSt…
jals1212 Dec 2, 2025
0a899e8
fix: ensure verifier and state checks only proceed if query code is p…
jals1212 Dec 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions src/runtime/server/lib/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { type H3Event, deleteCookie, getCookie, setCookie } from 'h3'
import { type H3Event, deleteCookie, getCookie, getQuery, setCookie } from 'h3'
import { getRequestURL } from 'h3'
import { FetchError } from 'ofetch'
import { snakeCase, upperFirst } from 'scule'
Expand Down Expand Up @@ -185,7 +185,11 @@ export async function handlePkceVerifier(event: H3Event) {
let verifier = getCookie(event, 'nuxt-auth-pkce')
if (verifier) {
deleteCookie(event, 'nuxt-auth-pkce')
return { code_verifier: verifier }

const query = getQuery<{ code?: string }>(event)
if (query.code) {
return { code_verifier: verifier }
}
}

// Create new verifier
Expand All @@ -208,7 +212,11 @@ export async function handleState(event: H3Event) {
let state = getCookie(event, 'nuxt-auth-state')
if (state) {
deleteCookie(event, 'nuxt-auth-state')
return state

const query = getQuery<{ code?: string }>(event)
if (query.code) {
return state
}
}

state = encodeBase64Url(getRandomBytes(8))
Expand Down