From d4b2c55ccff290c1596345e28a8e91a746d5f09c Mon Sep 17 00:00:00 2001 From: Brendan Forster Date: Thu, 19 Nov 2020 08:01:26 -0400 Subject: [PATCH 1/3] add new command specifically to support rebuilding module --- package.json | 1 + 1 file changed, 1 insertion(+) diff --git a/package.json b/package.json index f200f83f..9ed151c1 100644 --- a/package.json +++ b/package.json @@ -31,6 +31,7 @@ "types": "./keytar.d.ts", "scripts": { "install": "prebuild-install || node-gyp rebuild", + "build": "node-gyp rebuild", "lint": "npm run cpplint", "cpplint": "node-cpplint --filters legal-copyright,build-include,build-namespaces src/*.cc", "test": "npm run lint && npm rebuild && mocha --require babel-core/register spec/", From d62e1d391acc12192775786fa1f22174829b79ec Mon Sep 17 00:00:00 2001 From: Brendan Forster Date: Thu, 19 Nov 2020 08:06:06 -0400 Subject: [PATCH 2/3] ensure codeql always builds native module --- .github/workflows/codeql.yml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/.github/workflows/codeql.yml b/.github/workflows/codeql.yml index f9bc01d6..ee2ad64c 100644 --- a/.github/workflows/codeql.yml +++ b/.github/workflows/codeql.yml @@ -34,7 +34,9 @@ jobs: # Setup dependencies (and build native modules from source) - name: Install dependencies - run: npm install + run: | + npm install + npm run build # Run code analysis - name: Perform CodeQL Analysis From 6b2efd11e9638ea278836ea77fc2fd9b625f92b5 Mon Sep 17 00:00:00 2001 From: Brendan Forster Date: Thu, 19 Nov 2020 08:22:43 -0400 Subject: [PATCH 3/3] point to new command --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index 9ed151c1..78012e4a 100644 --- a/package.json +++ b/package.json @@ -30,7 +30,7 @@ ], "types": "./keytar.d.ts", "scripts": { - "install": "prebuild-install || node-gyp rebuild", + "install": "prebuild-install || npm run build", "build": "node-gyp rebuild", "lint": "npm run cpplint", "cpplint": "node-cpplint --filters legal-copyright,build-include,build-namespaces src/*.cc",