fix: raise MissingKeyError when import empty key set. #35

Author: lepture

src/joserfc/_keys.py

@@ -6,7 +6,12 @@
 from .rfc7518.rsa_key import RSAKey
 from .rfc7518.ec_key import ECKey
 from .rfc8037.okp_key import OKPKey
-from .errors import InvalidKeyIdError, InvalidKeyTypeError, MissingKeyTypeError
+from .errors import (
+    MissingKeyError,
+    InvalidKeyIdError,
+    InvalidKeyTypeError,
+    MissingKeyTypeError,
+)
 from .util import to_bytes
 
 __all__ = [
@@ -161,6 +166,9 @@ def import_key_set(cls, value: KeySetSerialization, parameters: KeyParameters |
         for data in value["keys"]:
             keys.append(cls.registry_cls.import_key(data, parameters=parameters))
 
+        if not keys:
+            raise MissingKeyError("No keys to import")
+
         return cls(keys)
 
     @classmethod

tests/jwk/test_jwk_set.py

@@ -1,13 +1,16 @@
 from unittest import TestCase
 
-from joserfc.errors import InvalidKeyTypeError, InvalidKeyIdError
+from joserfc.errors import InvalidKeyTypeError, InvalidKeyIdError, MissingKeyError
 from joserfc.jwk import KeySet, RSAKey, ECKey, OctKey
 from tests.keys import read_key
 
 KeySet.algorithm_keys["RS256"] = ["RSA"]
 
 
 class TestKeySet(TestCase):
+    def test_import_empty_key_set(self):
+        self.assertRaises(MissingKeyError, KeySet.import_key_set, {"keys": []})
+
     def test_generate_and_import_key_set(self):
         jwks1 = KeySet.generate_key_set("RSA", 2048)
         self.assertEqual(len(jwks1.keys), 4)