fix(jwk): raise InvalidKeyCurveError when generate ECKey with invalid crv

Author: lepture

src/joserfc/_rfc7518/ec_key.py

@@ -14,7 +14,7 @@
     SECP521R1,
 )
 from cryptography.hazmat.backends import default_backend
-from ..errors import InvalidExchangeKeyError
+from ..errors import InvalidExchangeKeyError, InvalidKeyCurveError
 from .._rfc7517.models import CurveKey
 from .._rfc7517.pem import CryptographyBinding
 from .._rfc7517.types import KeyParameters, AnyKey
@@ -51,7 +51,7 @@ def register_curve(cls, name: str, curve: t.Type[EllipticCurve]) -> None:
     @classmethod
     def generate_private_key(cls, name: str) -> EllipticCurvePrivateKey:
         if name not in cls._dss_curves:
-            raise ValueError("Invalid crv value: '{}'".format(name))
+            raise InvalidKeyCurveError("Invalid crv value: '{}'".format(name))
 
         curve = cls._dss_curves[name]()
         raw_key = generate_private_key(

tests/jwk/test_ec_key.py

@@ -1,6 +1,10 @@
 from unittest import TestCase
 from joserfc.jwk import ECKey, OctKey
-from joserfc.errors import InvalidExchangeKeyError, InvalidKeyTypeError
+from joserfc.errors import (
+    InvalidExchangeKeyError,
+    InvalidKeyTypeError,
+    InvalidKeyCurveError,
+)
 from tests.keys import read_key
 
 
@@ -50,7 +54,7 @@ def test_import_from_native_keys(self):
         self.assertEqual(key, ECKey.import_key(key.private_key))
 
     def test_generate_key(self):
-        self.assertRaises(ValueError, ECKey.generate_key, "Invalid")
+        self.assertRaises(InvalidKeyCurveError, ECKey.generate_key, "Invalid")
 
         key = ECKey.generate_key(private=True)
         self.assertTrue(key.is_private)