fix(aws-ec2): fix typo in resource identifier (#818)

rix0rrr · web-flow · commit bebfef03bfb8 · 2018-10-05T11:07:38.000+02:00
This will mutate deployed VPC resources, but I verified that the route table association can be replaced without the deployment getting stuck.

I did not verify it does not have on impact on availability for the duration.
diff --git a/packages/@aws-cdk/aws-autoscaling/test/integ.asg-w-classic-loadbalancer.expected.json b/packages/@aws-cdk/aws-autoscaling/test/integ.asg-w-classic-loadbalancer.expected.json
@@ -46,7 +46,7 @@
         ]
       }
     },
-    "VPCPublicSubnet1RouteTableAssociatioin249B4093": {
+    "VPCPublicSubnet1RouteTableAssociation0B0896DC": {
       "Type": "AWS::EC2::SubnetRouteTableAssociation",
       "Properties": {
         "RouteTableId": {
@@ -126,7 +126,7 @@
         ]
       }
     },
-    "VPCPublicSubnet2RouteTableAssociatioin766225D7": {
+    "VPCPublicSubnet2RouteTableAssociation5A808732": {
       "Type": "AWS::EC2::SubnetRouteTableAssociation",
       "Properties": {
         "RouteTableId": {
@@ -206,7 +206,7 @@
         ]
       }
     },
-    "VPCPublicSubnet3RouteTableAssociatioinF4E24B3B": {
+    "VPCPublicSubnet3RouteTableAssociation427FE0C6": {
       "Type": "AWS::EC2::SubnetRouteTableAssociation",
       "Properties": {
         "RouteTableId": {
@@ -286,7 +286,7 @@
         ]
       }
     },
-    "VPCPrivateSubnet1RouteTableAssociatioin77F7CA18": {
+    "VPCPrivateSubnet1RouteTableAssociation347902D1": {
       "Type": "AWS::EC2::SubnetRouteTableAssociation",
       "Properties": {
         "RouteTableId": {
@@ -340,7 +340,7 @@
         ]
       }
     },
-    "VPCPrivateSubnet2RouteTableAssociatioinC31995B4": {
+    "VPCPrivateSubnet2RouteTableAssociation0C73D413": {
       "Type": "AWS::EC2::SubnetRouteTableAssociation",
       "Properties": {
         "RouteTableId": {
@@ -394,7 +394,7 @@
         ]
       }
     },
-    "VPCPrivateSubnet3RouteTableAssociatioin3B0B6B38": {
+    "VPCPrivateSubnet3RouteTableAssociationC28D144E": {
       "Type": "AWS::EC2::SubnetRouteTableAssociation",
       "Properties": {
         "RouteTableId": {
diff --git a/packages/@aws-cdk/aws-autoscaling/test/integ.asg-w-elbv2.expected.json b/packages/@aws-cdk/aws-autoscaling/test/integ.asg-w-elbv2.expected.json
@@ -46,7 +46,7 @@
         ]
       }
     },
-    "VPCPublicSubnet1RouteTableAssociatioin249B4093": {
+    "VPCPublicSubnet1RouteTableAssociation0B0896DC": {
       "Type": "AWS::EC2::SubnetRouteTableAssociation",
       "Properties": {
         "RouteTableId": {
@@ -126,7 +126,7 @@
         ]
       }
     },
-    "VPCPublicSubnet2RouteTableAssociatioin766225D7": {
+    "VPCPublicSubnet2RouteTableAssociation5A808732": {
       "Type": "AWS::EC2::SubnetRouteTableAssociation",
       "Properties": {
         "RouteTableId": {
@@ -206,7 +206,7 @@
         ]
       }
     },
-    "VPCPrivateSubnet1RouteTableAssociatioin77F7CA18": {
+    "VPCPrivateSubnet1RouteTableAssociation347902D1": {
       "Type": "AWS::EC2::SubnetRouteTableAssociation",
       "Properties": {
         "RouteTableId": {
@@ -260,7 +260,7 @@
         ]
       }
     },
-    "VPCPrivateSubnet2RouteTableAssociatioinC31995B4": {
+    "VPCPrivateSubnet2RouteTableAssociation0C73D413": {
       "Type": "AWS::EC2::SubnetRouteTableAssociation",
       "Properties": {
         "RouteTableId": {
diff --git a/packages/@aws-cdk/aws-ec2/lib/vpc.ts b/packages/@aws-cdk/aws-ec2/lib/vpc.ts
@@ -486,7 +486,7 @@ export class VpcSubnet extends VpcSubnetRef implements cdk.ITaggable {
     this.routeTableId = table.ref;
 
     // Associate the public route table for this subnet, to this subnet
-    const routeAssoc = new cloudformation.SubnetRouteTableAssociationResource(this, 'RouteTableAssociatioin', {
+    const routeAssoc = new cloudformation.SubnetRouteTableAssociationResource(this, 'RouteTableAssociation', {
       subnetId: this.subnetId,
       routeTableId: table.ref
     });
diff --git a/packages/@aws-cdk/aws-ec2/test/integ.vpc.expected.json b/packages/@aws-cdk/aws-ec2/test/integ.vpc.expected.json
@@ -46,7 +46,7 @@
         ]
       }
     },
-    "MyVpcPublicSubnet1RouteTableAssociatioin3562612E": {
+    "MyVpcPublicSubnet1RouteTableAssociation2ECEE1CB": {
       "Type": "AWS::EC2::SubnetRouteTableAssociation",
       "Properties": {
         "RouteTableId": {
@@ -126,7 +126,7 @@
         ]
       }
     },
-    "MyVpcPublicSubnet2RouteTableAssociatioin8E74FB35": {
+    "MyVpcPublicSubnet2RouteTableAssociation227DE78D": {
       "Type": "AWS::EC2::SubnetRouteTableAssociation",
       "Properties": {
         "RouteTableId": {
@@ -206,7 +206,7 @@
         ]
       }
     },
-    "MyVpcPublicSubnet3RouteTableAssociatioinA3FD1B71": {
+    "MyVpcPublicSubnet3RouteTableAssociation5C27DDA4": {
       "Type": "AWS::EC2::SubnetRouteTableAssociation",
       "Properties": {
         "RouteTableId": {
@@ -286,7 +286,7 @@
         ]
       }
     },
-    "MyVpcPrivateSubnet1RouteTableAssociatioin90CF6BAB": {
+    "MyVpcPrivateSubnet1RouteTableAssociation56D38C7E": {
       "Type": "AWS::EC2::SubnetRouteTableAssociation",
       "Properties": {
         "RouteTableId": {
@@ -340,7 +340,7 @@
         ]
       }
     },
-    "MyVpcPrivateSubnet2RouteTableAssociatioin803693C0": {
+    "MyVpcPrivateSubnet2RouteTableAssociation86A610DA": {
       "Type": "AWS::EC2::SubnetRouteTableAssociation",
       "Properties": {
         "RouteTableId": {
@@ -394,7 +394,7 @@
         ]
       }
     },
-    "MyVpcPrivateSubnet3RouteTableAssociatioinFB4A6FE6": {
+    "MyVpcPrivateSubnet3RouteTableAssociationD951741C": {
       "Type": "AWS::EC2::SubnetRouteTableAssociation",
       "Properties": {
         "RouteTableId": {
diff --git a/packages/@aws-cdk/aws-elasticloadbalancing/test/integ.elb.expected.json b/packages/@aws-cdk/aws-elasticloadbalancing/test/integ.elb.expected.json
@@ -46,7 +46,7 @@
         ]
       }
     },
-    "VPCPublicSubnet1RouteTableAssociatioin249B4093": {
+    "VPCPublicSubnet1RouteTableAssociation0B0896DC": {
       "Type": "AWS::EC2::SubnetRouteTableAssociation",
       "Properties": {
         "RouteTableId": {
@@ -126,7 +126,7 @@
         ]
       }
     },
-    "VPCPrivateSubnet1RouteTableAssociatioin77F7CA18": {
+    "VPCPrivateSubnet1RouteTableAssociation347902D1": {
       "Type": "AWS::EC2::SubnetRouteTableAssociation",
       "Properties": {
         "RouteTableId": {
diff --git a/packages/@aws-cdk/aws-elasticloadbalancingv2/test/integ.alb.expected.json b/packages/@aws-cdk/aws-elasticloadbalancingv2/test/integ.alb.expected.json
@@ -46,7 +46,7 @@
         ]
       }
     },
-    "VPCPublicSubnet1RouteTableAssociatioin249B4093": {
+    "VPCPublicSubnet1RouteTableAssociation0B0896DC": {
       "Type": "AWS::EC2::SubnetRouteTableAssociation",
       "Properties": {
         "RouteTableId": {
@@ -126,7 +126,7 @@
         ]
       }
     },
-    "VPCPublicSubnet2RouteTableAssociatioin766225D7": {
+    "VPCPublicSubnet2RouteTableAssociation5A808732": {
       "Type": "AWS::EC2::SubnetRouteTableAssociation",
       "Properties": {
         "RouteTableId": {
@@ -206,7 +206,7 @@
         ]
       }
     },
-    "VPCPrivateSubnet1RouteTableAssociatioin77F7CA18": {
+    "VPCPrivateSubnet1RouteTableAssociation347902D1": {
       "Type": "AWS::EC2::SubnetRouteTableAssociation",
       "Properties": {
         "RouteTableId": {
@@ -260,7 +260,7 @@
         ]
       }
     },
-    "VPCPrivateSubnet2RouteTableAssociatioinC31995B4": {
+    "VPCPrivateSubnet2RouteTableAssociation0C73D413": {
       "Type": "AWS::EC2::SubnetRouteTableAssociation",
       "Properties": {
         "RouteTableId": {
diff --git a/packages/@aws-cdk/aws-elasticloadbalancingv2/test/integ.nlb.expected.json b/packages/@aws-cdk/aws-elasticloadbalancingv2/test/integ.nlb.expected.json
@@ -46,7 +46,7 @@
         ]
       }
     },
-    "VPCPublicSubnet1RouteTableAssociatioin249B4093": {
+    "VPCPublicSubnet1RouteTableAssociation0B0896DC": {
       "Type": "AWS::EC2::SubnetRouteTableAssociation",
       "Properties": {
         "RouteTableId": {
@@ -126,7 +126,7 @@
         ]
       }
     },
-    "VPCPublicSubnet2RouteTableAssociatioin766225D7": {
+    "VPCPublicSubnet2RouteTableAssociation5A808732": {
       "Type": "AWS::EC2::SubnetRouteTableAssociation",
       "Properties": {
         "RouteTableId": {
@@ -206,7 +206,7 @@
         ]
       }
     },
-    "VPCPrivateSubnet1RouteTableAssociatioin77F7CA18": {
+    "VPCPrivateSubnet1RouteTableAssociation347902D1": {
       "Type": "AWS::EC2::SubnetRouteTableAssociation",
       "Properties": {
         "RouteTableId": {
@@ -260,7 +260,7 @@
         ]
       }
     },
-    "VPCPrivateSubnet2RouteTableAssociatioinC31995B4": {
+    "VPCPrivateSubnet2RouteTableAssociation0C73D413": {
       "Type": "AWS::EC2::SubnetRouteTableAssociation",
       "Properties": {
         "RouteTableId": {
diff --git a/packages/@aws-cdk/aws-lambda/test/integ.vpc-lambda.expected.json b/packages/@aws-cdk/aws-lambda/test/integ.vpc-lambda.expected.json
@@ -46,7 +46,7 @@
         ]
       }
     },
-    "VPCPublicSubnet1RouteTableAssociatioin249B4093": {
+    "VPCPublicSubnet1RouteTableAssociation0B0896DC": {
       "Type": "AWS::EC2::SubnetRouteTableAssociation",
       "Properties": {
         "RouteTableId": {
@@ -126,7 +126,7 @@
         ]
       }
     },
-    "VPCPublicSubnet2RouteTableAssociatioin766225D7": {
+    "VPCPublicSubnet2RouteTableAssociation5A808732": {
       "Type": "AWS::EC2::SubnetRouteTableAssociation",
       "Properties": {
         "RouteTableId": {
@@ -206,7 +206,7 @@
         ]
       }
     },
-    "VPCPrivateSubnet1RouteTableAssociatioin77F7CA18": {
+    "VPCPrivateSubnet1RouteTableAssociation347902D1": {
       "Type": "AWS::EC2::SubnetRouteTableAssociation",
       "Properties": {
         "RouteTableId": {
@@ -260,7 +260,7 @@
         ]
       }
     },
-    "VPCPrivateSubnet2RouteTableAssociatioinC31995B4": {
+    "VPCPrivateSubnet2RouteTableAssociation0C73D413": {
       "Type": "AWS::EC2::SubnetRouteTableAssociation",
       "Properties": {
         "RouteTableId": {
diff --git a/packages/@aws-cdk/aws-rds/test/integ.cluster.expected.json b/packages/@aws-cdk/aws-rds/test/integ.cluster.expected.json
@@ -46,7 +46,7 @@
         ]
       }
     },
-    "VPCPublicSubnet1RouteTableAssociatioin249B4093": {
+    "VPCPublicSubnet1RouteTableAssociation0B0896DC": {
       "Type": "AWS::EC2::SubnetRouteTableAssociation",
       "Properties": {
         "RouteTableId": {
@@ -126,7 +126,7 @@
         ]
       }
     },
-    "VPCPublicSubnet2RouteTableAssociatioin766225D7": {
+    "VPCPublicSubnet2RouteTableAssociation5A808732": {
       "Type": "AWS::EC2::SubnetRouteTableAssociation",
       "Properties": {
         "RouteTableId": {
@@ -206,7 +206,7 @@
         ]
       }
     },
-    "VPCPrivateSubnet1RouteTableAssociatioin77F7CA18": {
+    "VPCPrivateSubnet1RouteTableAssociation347902D1": {
       "Type": "AWS::EC2::SubnetRouteTableAssociation",
       "Properties": {
         "RouteTableId": {
@@ -260,7 +260,7 @@
         ]
       }
     },
-    "VPCPrivateSubnet2RouteTableAssociatioinC31995B4": {
+    "VPCPrivateSubnet2RouteTableAssociation0C73D413": {
       "Type": "AWS::EC2::SubnetRouteTableAssociation",
       "Properties": {
         "RouteTableId": {
diff --git a/packages/@aws-cdk/aws-route53/test/integ.route53.expected.json b/packages/@aws-cdk/aws-route53/test/integ.route53.expected.json
@@ -46,7 +46,7 @@
         ]
       }
     },
-    "VPCPublicSubnet1RouteTableAssociatioin249B4093": {
+    "VPCPublicSubnet1RouteTableAssociation0B0896DC": {
       "Type": "AWS::EC2::SubnetRouteTableAssociation",
       "Properties": {
         "RouteTableId": {
@@ -126,7 +126,7 @@
         ]
       }
     },
-    "VPCPublicSubnet2RouteTableAssociatioin766225D7": {
+    "VPCPublicSubnet2RouteTableAssociation5A808732": {
       "Type": "AWS::EC2::SubnetRouteTableAssociation",
       "Properties": {
         "RouteTableId": {
@@ -206,7 +206,7 @@
         ]
       }
     },
-    "VPCPublicSubnet3RouteTableAssociatioinF4E24B3B": {
+    "VPCPublicSubnet3RouteTableAssociation427FE0C6": {
       "Type": "AWS::EC2::SubnetRouteTableAssociation",
       "Properties": {
         "RouteTableId": {
@@ -286,7 +286,7 @@
         ]
       }
     },
-    "VPCPrivateSubnet1RouteTableAssociatioin77F7CA18": {
+    "VPCPrivateSubnet1RouteTableAssociation347902D1": {
       "Type": "AWS::EC2::SubnetRouteTableAssociation",
       "Properties": {
         "RouteTableId": {
@@ -340,7 +340,7 @@
         ]
       }
     },
-    "VPCPrivateSubnet2RouteTableAssociatioinC31995B4": {
+    "VPCPrivateSubnet2RouteTableAssociation0C73D413": {
       "Type": "AWS::EC2::SubnetRouteTableAssociation",
       "Properties": {
         "RouteTableId": {
@@ -394,7 +394,7 @@
         ]
       }
     },
-    "VPCPrivateSubnet3RouteTableAssociatioin3B0B6B38": {
+    "VPCPrivateSubnet3RouteTableAssociationC28D144E": {
       "Type": "AWS::EC2::SubnetRouteTableAssociation",
       "Properties": {
         "RouteTableId": {

Original file line number	Diff line number	Diff line change
`@@ -46,7 +46,7 @@`
`46`	`46`	`]`
`47`	`47`	`}`
`48`	`48`	`},`
`49`		`- "VPCPublicSubnet1RouteTableAssociatioin249B4093": {`
	`49`	`+ "VPCPublicSubnet1RouteTableAssociation0B0896DC": {`
`50`	`50`	`"Type": "AWS::EC2::SubnetRouteTableAssociation",`
`51`	`51`	`"Properties": {`
`52`	`52`	`"RouteTableId": {`
`@@ -126,7 +126,7 @@`
`126`	`126`	`]`
`127`	`127`	`}`
`128`	`128`	`},`
`129`		`- "VPCPublicSubnet2RouteTableAssociatioin766225D7": {`
	`129`	`+ "VPCPublicSubnet2RouteTableAssociation5A808732": {`
`130`	`130`	`"Type": "AWS::EC2::SubnetRouteTableAssociation",`
`131`	`131`	`"Properties": {`
`132`	`132`	`"RouteTableId": {`
`@@ -206,7 +206,7 @@`
`206`	`206`	`]`
`207`	`207`	`}`
`208`	`208`	`},`
`209`		`- "VPCPublicSubnet3RouteTableAssociatioinF4E24B3B": {`
	`209`	`+ "VPCPublicSubnet3RouteTableAssociation427FE0C6": {`
`210`	`210`	`"Type": "AWS::EC2::SubnetRouteTableAssociation",`
`211`	`211`	`"Properties": {`
`212`	`212`	`"RouteTableId": {`
`@@ -286,7 +286,7 @@`
`286`	`286`	`]`
`287`	`287`	`}`
`288`	`288`	`},`
`289`		`- "VPCPrivateSubnet1RouteTableAssociatioin77F7CA18": {`
	`289`	`+ "VPCPrivateSubnet1RouteTableAssociation347902D1": {`
`290`	`290`	`"Type": "AWS::EC2::SubnetRouteTableAssociation",`
`291`	`291`	`"Properties": {`
`292`	`292`	`"RouteTableId": {`
`@@ -340,7 +340,7 @@`
`340`	`340`	`]`
`341`	`341`	`}`
`342`	`342`	`},`
`343`		`- "VPCPrivateSubnet2RouteTableAssociatioinC31995B4": {`
	`343`	`+ "VPCPrivateSubnet2RouteTableAssociation0C73D413": {`
`344`	`344`	`"Type": "AWS::EC2::SubnetRouteTableAssociation",`
`345`	`345`	`"Properties": {`
`346`	`346`	`"RouteTableId": {`
`@@ -394,7 +394,7 @@`
`394`	`394`	`]`
`395`	`395`	`}`
`396`	`396`	`},`
`397`		`- "VPCPrivateSubnet3RouteTableAssociatioin3B0B6B38": {`
	`397`	`+ "VPCPrivateSubnet3RouteTableAssociationC28D144E": {`
`398`	`398`	`"Type": "AWS::EC2::SubnetRouteTableAssociation",`
`399`	`399`	`"Properties": {`
`400`	`400`	`"RouteTableId": {`