From d4417744a64bf08d99a96c96af3fbe86c0972d8c Mon Sep 17 00:00:00 2001 From: Edgar Hernandez Date: Mon, 28 Dec 2020 15:13:05 +0000 Subject: [PATCH 1/2] Delete Gemfile.lock File was added as part of the fix to the logger but according to [Yehuda Katz](https://yehudakatz.com/2010/12/16/clarifying-the-roles-of-the-gemspec-and-gemfile/) this was a mistake: > When developing a gem, use the gemspec method in your Gemfile to avoid duplication. In general, a gem's Gemfile should contain the Rubygems source and a single gemspec line. Do not check your Gemfile.lock into version control, since it enforces precision that does not exist in the gem command, which is used to install gems in practice. Even if the precision could be enforced, you wouldn't want it, since it would prevent people from using your library with versions of its dependencies that are different from the ones you used to develop the gem. > When developing an app, check in your Gemfile.lock, since you will use the bundler tool across all machines, and the precision enforced by bundler is extremely desirable for applications. https://yehudakatz.com/2010/12/16/clarifying-the-roles-of-the-gemspec-and-gemfile/ --- Gemfile.lock | 36 ------------------------------------ 1 file changed, 36 deletions(-) delete mode 100644 Gemfile.lock diff --git a/Gemfile.lock b/Gemfile.lock deleted file mode 100644 index 88072aa..0000000 --- a/Gemfile.lock +++ /dev/null @@ -1,36 +0,0 @@ -PATH - remote: . - specs: - aws_lambda_ric (1.0.1) - -GEM - remote: https://rubygems.org/ - specs: - activesupport (6.0.3.4) - concurrent-ruby (~> 1.0, >= 1.0.2) - i18n (>= 0.7, < 2) - minitest (~> 5.1) - tzinfo (~> 1.1) - zeitwerk (~> 2.2, >= 2.2.2) - concurrent-ruby (1.1.7) - i18n (1.8.5) - concurrent-ruby (~> 1.0) - minitest (5.14.2) - rake (13.0.1) - thread_safe (0.3.6) - tzinfo (1.2.8) - thread_safe (~> 0.1) - zeitwerk (2.4.2) - -PLATFORMS - ruby - -DEPENDENCIES - activesupport (~> 6.0.1) - aws_lambda_ric! - bundler (>= 2.0) - minitest (~> 5.0) - rake (~> 13.0) - -BUNDLED WITH - 2.2.0.rc.2 From cf9e0afa7d4d70939c4af29abc8c7660d63995fc Mon Sep 17 00:00:00 2001 From: Edgar Hernandez Date: Thu, 21 Jan 2021 13:26:57 +0000 Subject: [PATCH 2/2] Add Gemfile.lock to the files ignored by git For a library this file is better if it is not included ever: > Do not check your Gemfile.lock into version control, since it enforces precision that does not exist in the gem command, which is used to install gems in practice. Even if the precision could be enforced, you wouldn't want it, since it would prevent people from using your library with versions of its dependencies that are different from the ones you used to develop the gem. https://yehudakatz.com/2010/12/16/clarifying-the-roles-of-the-gemspec-and-gemfile/ --- .gitignore | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.gitignore b/.gitignore index c86a24b..f6b393d 100644 --- a/.gitignore +++ b/.gitignore @@ -9,4 +9,5 @@ vendor test/examples/hello-world-docker/pkg *.iml -.DS_Store \ No newline at end of file +.DS_Store +Gemfile.lock