From fe8076eb7cba6db14e86fb1e0a5bb488070d91fb Mon Sep 17 00:00:00 2001 From: Achim Fritz Date: Tue, 18 Nov 2025 08:51:06 +0100 Subject: [PATCH 1/4] [TASK] phpstan for TYPO3 14 LocalizationController has been removed in v14 s. https://review.typo3.org/c/Packages/TYPO3.CMS/+/90489 Our XClass is only required for TYPO3 < v11 --- Build/phpstan14.neon | 1 + 1 file changed, 1 insertion(+) diff --git a/Build/phpstan14.neon b/Build/phpstan14.neon index 785bbae4..a97d3c6d 100644 --- a/Build/phpstan14.neon +++ b/Build/phpstan14.neon @@ -17,4 +17,5 @@ parameters: - %currentWorkingDirectory%/Classes/ContentDefender - %currentWorkingDirectory%/Classes/Events/BeforeContainerPreviewIsRenderedEvent.php - %currentWorkingDirectory%/Tests/Functional/Integrity/IntegrityTest.php + - %currentWorkingDirectory%/Classes/Xclasses/LocalizationController.php From 4a0476c6f91cfdd8e1b9c5148a9c832e43534b16 Mon Sep 17 00:00:00 2001 From: Achim Fritz Date: Tue, 18 Nov 2025 18:07:39 +0100 Subject: [PATCH 2/4] [TASK] acceptance tests * fix standalone-chromium version * window-size for codeception * s. https://issues.chromium.org/issues/362522328 * s. https://review.typo3.org/c/Packages/TYPO3.CMS/+/88500 --- Build/Scripts/runTests.sh | 3 ++- Tests/codeception.yml | 7 +++++-- 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/Build/Scripts/runTests.sh b/Build/Scripts/runTests.sh index 000de037..c8fa9c48 100755 --- a/Build/Scripts/runTests.sh +++ b/Build/Scripts/runTests.sh @@ -433,7 +433,8 @@ IMAGE_PHP="ghcr.io/typo3/core-testing-$(echo "php${PHP_VERSION}" | sed -e 's/\./ IMAGE_NODEJS="ghcr.io/typo3/core-testing-nodejs18:latest" IMAGE_NODEJS_CHROME="ghcr.io/typo3/core-testing-nodejs18-chrome:latest" IMAGE_ALPINE="docker.io/alpine:3.8" -IMAGE_SELENIUM="docker.io/selenium/standalone-chrome:4.11.0-20230801" +# HEADS UP: We need to pin to <132 for --headless=old support until https://issues.chromium.org/issues/362522328 is resolved +IMAGE_SELENIUM="docker.io/selenium/standalone-chromium:131.0-20250101" IMAGE_MARIADB="docker.io/mariadb:${DBMS_VERSION}" IMAGE_MYSQL="docker.io/mysql:${DBMS_VERSION}" IMAGE_POSTGRES="docker.io/postgres:${DBMS_VERSION}-alpine" diff --git a/Tests/codeception.yml b/Tests/codeception.yml index 7f18817f..defe5aff 100644 --- a/Tests/codeception.yml +++ b/Tests/codeception.yml @@ -24,7 +24,10 @@ modules: port: 9515 path: / # @todo: adapt tests to not break with a defined window size (as in v12/v13) - #window_size: 1280x1024 + window_size: 1280x1024 + capabilities: + goog:chromeOptions: + args: ["window-size=1280,1024"] env: ci: @@ -54,4 +57,4 @@ env: args: ["no-sandbox", "disable-gpu"] params: - parameters.yml - - env \ No newline at end of file + - env From 02af11ef86e862323ad1a2d3df18f2078508df0f Mon Sep 17 00:00:00 2001 From: Achim Fritz Date: Sat, 22 Nov 2025 11:11:54 +0100 Subject: [PATCH 3/4] [TASK] disable v11 acceptance tests --- .github/workflows/ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 51a1a800..eb0fedb5 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -58,7 +58,7 @@ jobs: - name: Acceptance Tests run: Build/Scripts/runTests.sh -p ${{ matrix.php }} -t ${{ matrix.TYPO3 }} -s acceptance -- --fail-fast - if: matrix.TYPO3 != '14' + if: matrix.TYPO3 != '11' && matrix.TYPO3 != '14' - name: Archive acceptance tests results uses: actions/upload-artifact@v4 From 45439ef2b1300fd2dc1147c58f4994691e45d4b9 Mon Sep 17 00:00:00 2001 From: Achim Fritz Date: Sat, 22 Nov 2025 11:18:05 +0100 Subject: [PATCH 4/4] [TASK] make v13 acceptance tests running again s. https://review.typo3.org/c/Packages/TYPO3.CMS/+/91447 --- Tests/Acceptance/Support/PageTreeV13.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Tests/Acceptance/Support/PageTreeV13.php b/Tests/Acceptance/Support/PageTreeV13.php index 9ecf5dc4..6d7a40ed 100644 --- a/Tests/Acceptance/Support/PageTreeV13.php +++ b/Tests/Acceptance/Support/PageTreeV13.php @@ -121,7 +121,7 @@ protected function ensureTreeNodeIsOpen(string $nodeText, RemoteWebElement $cont }); try { - $context->findElement(\Facebook\WebDriver\WebDriverBy::cssSelector('.node-toggle > typo3-backend-icon[identifier=\'actions-chevron-right\']'))->click(); + $context->findElement(\Facebook\WebDriver\WebDriverBy::cssSelector('.node-toggle > typo3-backend-icon[identifier=\'actions-chevron-end\']'))->click(); } catch (\Facebook\WebDriver\Exception\NoSuchElementException $e) { // element not found so it may be already opened... } catch (\Facebook\WebDriver\Exception\ElementNotVisibleException $e) {