From 3cc3692889d21f7413c0911d01b54c8a499b2e4a Mon Sep 17 00:00:00 2001 From: Norman Fomferra Date: Tue, 18 Feb 2025 14:33:17 +0100 Subject: [PATCH 1/3] started 0.1.4 dev --- chartlets.js/package-lock.json | 2 +- chartlets.js/packages/lib/package.json | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/chartlets.js/package-lock.json b/chartlets.js/package-lock.json index f8d5105..93de416 100644 --- a/chartlets.js/package-lock.json +++ b/chartlets.js/package-lock.json @@ -8195,7 +8195,7 @@ }, "packages/lib": { "name": "chartlets", - "version": "0.1.3", + "version": "0.1.4-dev.0", "license": "MIT", "dependencies": { "microdiff": "^1.4", diff --git a/chartlets.js/packages/lib/package.json b/chartlets.js/packages/lib/package.json index 8f4f846..aebb3b4 100644 --- a/chartlets.js/packages/lib/package.json +++ b/chartlets.js/packages/lib/package.json @@ -1,6 +1,6 @@ { "name": "chartlets", - "version": "0.1.3", + "version": "0.1.4-dev.0", "description": "An experimental library for integrating interactive charts into existing JavaScript applications.", "type": "module", "files": [ From b052b25b7485235f0397b737c24572db71d9082a Mon Sep 17 00:00:00 2001 From: Norman Fomferra Date: Tue, 18 Feb 2025 14:33:35 +0100 Subject: [PATCH 2/3] no longer log in common situations --- chartlets.js/CHANGES.md | 5 +++++ .../packages/lib/src/actions/helpers/getInputValues.ts | 10 ++++++++-- chartlets.js/packages/lib/src/components/Component.tsx | 9 ++++++--- 3 files changed, 19 insertions(+), 5 deletions(-) diff --git a/chartlets.js/CHANGES.md b/chartlets.js/CHANGES.md index 6f8867d..146fadd 100644 --- a/chartlets.js/CHANGES.md +++ b/chartlets.js/CHANGES.md @@ -1,3 +1,8 @@ +## Version 0.1.4 (in development) + +* In `chartlets.js` we no longer emit warnings an errors in common + situations to avoid too much spam in the browser console. + ## Version 0.1.3 (from 2025/01/28) * **Chore:** Version bump to align CI process with GitHub release flow. diff --git a/chartlets.js/packages/lib/src/actions/helpers/getInputValues.ts b/chartlets.js/packages/lib/src/actions/helpers/getInputValues.ts index 451bbea..544a7e1 100644 --- a/chartlets.js/packages/lib/src/actions/helpers/getInputValues.ts +++ b/chartlets.js/packages/lib/src/actions/helpers/getInputValues.ts @@ -44,12 +44,18 @@ export function getInputValue( } else if (isHostChannel(input) && hostStore) { inputValue = getInputValueFromHostStore(hostStore, property); } else { - console.warn(`input with unknown data source:`, input); + // We no longer log, as the situation is quite common if a + // component has not yet been rendered. + // Enable logging for debugging only: + // console.warn(`input with unknown data source:`, input); } if (inputValue === undefined || inputValue === noValue) { // We use null, because undefined is not JSON-serializable. inputValue = null; - console.warn(`value is undefined for input`, input); + // We no longer log, as the situation is quite common if a + // component has not yet been rendered. + // Enable logging for debugging only: + // console.warn(`value is undefined for input`, input); } return inputValue; } diff --git a/chartlets.js/packages/lib/src/components/Component.tsx b/chartlets.js/packages/lib/src/components/Component.tsx index 203878e..238e199 100644 --- a/chartlets.js/packages/lib/src/components/Component.tsx +++ b/chartlets.js/packages/lib/src/components/Component.tsx @@ -12,9 +12,12 @@ export function Component(props: ComponentProps) { if (typeof ActualComponent === "function") { return ; } else { - console.error( - `chartlets: invalid component type encountered: ${componentType}`, - ); + // We no longer log, as the situation is quite common + // and users can not do anything against it. + // Enable error logging for debugging only: + // console.error( + // `chartlets: invalid component type encountered: ${componentType}`, + // ); return null; } } From b2ef93ae1285fe0217767bd28bac58e38fb0a183 Mon Sep 17 00:00:00 2001 From: Norman Fomferra Date: Mon, 24 Feb 2025 15:24:24 +0100 Subject: [PATCH 3/3] Update chartlets.js/CHANGES.md Co-authored-by: b-yogesh --- chartlets.js/CHANGES.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/chartlets.js/CHANGES.md b/chartlets.js/CHANGES.md index 146fadd..bfb18da 100644 --- a/chartlets.js/CHANGES.md +++ b/chartlets.js/CHANGES.md @@ -1,6 +1,6 @@ ## Version 0.1.4 (in development) -* In `chartlets.js` we no longer emit warnings an errors in common +* In `chartlets.js` we no longer emit warnings and errors in common situations to avoid too much spam in the browser console. ## Version 0.1.3 (from 2025/01/28)