From 0c266616134a3cb44e9d4632fb767c9c8d9ef7b6 Mon Sep 17 00:00:00 2001 From: Spandan Garg Date: Fri, 18 Feb 2022 16:16:55 -0700 Subject: [PATCH] PERF: Optimize Reader.TypeDeserializerCache.cs --- src/XmlGridReader.Benchmarks/Benchmarks.cs | 1 + src/XmlGridReader/Reader.TypeDeserializerCache.cs | 6 +++--- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/src/XmlGridReader.Benchmarks/Benchmarks.cs b/src/XmlGridReader.Benchmarks/Benchmarks.cs index 883f53d..eff4f8b 100644 --- a/src/XmlGridReader.Benchmarks/Benchmarks.cs +++ b/src/XmlGridReader.Benchmarks/Benchmarks.cs @@ -11,6 +11,7 @@ namespace XmlGridReader.Benchmarks { [RankColumn(NumeralSystem.Arabic)] + [MemoryDiagnoser] public class Benchmarks { private string xml; diff --git a/src/XmlGridReader/Reader.TypeDeserializerCache.cs b/src/XmlGridReader/Reader.TypeDeserializerCache.cs index 7853ddc..da00731 100644 --- a/src/XmlGridReader/Reader.TypeDeserializerCache.cs +++ b/src/XmlGridReader/Reader.TypeDeserializerCache.cs @@ -44,7 +44,7 @@ private Func GetDeserializer( { reader.ReadRow(); - if (!reader.Columns.Any()) + if (reader.Columns.Count == 0) { throw new InvalidOperationException("No columns"); } @@ -97,12 +97,12 @@ private int ComputeHashCode(List fields) public bool Equals(DeserializerKey other) { - if (hashCode != other.hashCode || fields.Count() != other.fields.Count()) + if (hashCode != other.hashCode || fields.Count != other.fields.Count) { return false; } - for (int i = 0; i < fields.Count(); i++) + for (int i = 0; i < fields.Count; i++) { if (fields[i] != other.fields[i]) {