From b9f497f92b0ed5a024ecc0f0078e947f16fcca77 Mon Sep 17 00:00:00 2001
From: Marek Skrobacki <skrobul@skrobul.com>
Date: Thu, 21 Dec 2023 13:01:19 +0000
Subject: [PATCH] task detail: add Save button

This PR adds an explicit "Save" button on the task detail screen.
I have added this button mostly to scratch my own itch that bothered me
for a long time, but later on I found that others also find clicking
"Back" button to save non-intuitive and disrupting to the workflow.
My main issue is that when adding new task, my eyes start at the top,
then follow all fields to the bottom, where I expect some sort of
confirmation button.

Please see #174 for the discussion about it.
---
 .../foreground/tasklist/TaskDetailFragment.kt        |  9 +++++++++
 app/src/main/res/layout/fragment_task_detail.xml     | 12 ++++++++++++
 app/src/main/res/values/strings.xml                  |  1 +
 3 files changed, 22 insertions(+)

diff --git a/app/src/main/java/me/bgregos/foreground/tasklist/TaskDetailFragment.kt b/app/src/main/java/me/bgregos/foreground/tasklist/TaskDetailFragment.kt
index e6d194b..0cf8b2d 100644
--- a/app/src/main/java/me/bgregos/foreground/tasklist/TaskDetailFragment.kt
+++ b/app/src/main/java/me/bgregos/foreground/tasklist/TaskDetailFragment.kt
@@ -335,6 +335,15 @@ class TaskDetailFragment : Fragment() {
             viewModel.currentTask?.let { viewModel.delete(it) }
         }
 
+        binding.actionSave.setOnClickListener {
+            if (twoPane) {
+                activity?.supportFragmentManager?.beginTransaction()?.tabletDetailAnimations()
+                        ?.remove(this@TaskDetailFragment)?.commit()
+            } else {
+                activity?.supportFragmentManager?.popBackStack()
+            }
+        }
+
         return binding.root
     }
 
diff --git a/app/src/main/res/layout/fragment_task_detail.xml b/app/src/main/res/layout/fragment_task_detail.xml
index 00ba63d..2af3a42 100644
--- a/app/src/main/res/layout/fragment_task_detail.xml
+++ b/app/src/main/res/layout/fragment_task_detail.xml
@@ -167,6 +167,18 @@
             android:layout_margin="2dp"
             android:layout_gravity="end" />
 
+        <com.google.android.material.button.MaterialButton
+            android:id="@+id/action_save"
+            style="@style/Widget.MaterialComponents.Button.TextButton.Icon"
+            android:layout_width="wrap_content"
+            android:layout_height="wrap_content"
+            android:layout_gravity="end"
+            android:layout_margin="2dp"
+            android:text="@string/save"
+            android:textColor="#FFFFFF"
+            app:icon="@drawable/ic_baseline_description_24"
+            app:iconTint="#FFFFFF" />
+
     </LinearLayout>
     
 </LinearLayout>
diff --git a/app/src/main/res/values/strings.xml b/app/src/main/res/values/strings.xml
index 9555335..d554cef 100644
--- a/app/src/main/res/values/strings.xml
+++ b/app/src/main/res/values/strings.xml
@@ -82,6 +82,7 @@
     <string name="add_task">Add Task</string>
     <string name="delete">Delete</string>
     <string name="complete">Mark Completed</string>
+    <string name="save">Save</string>
     <string name="select_filter_type">Select Filter Type</string>
     <string name="add_a_filter">Add a filter</string>
     <string name="filter_add_warning">Please fill out all fields before adding.</string>