-
Notifications
You must be signed in to change notification settings - Fork 0
Add attachments module with S3-backed signed upload/download flow #8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
capcom6
merged 1 commit into
master
from
codex/design-attachments-module-with-abstracted-fields
Apr 23, 2026
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| package attachments | ||
|
|
||
| type Config struct { | ||
| MaxSize uint64 | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| // Package attachments provides domain, repository and service logic for task attachments. | ||
| package attachments |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,77 @@ | ||
| package attachments | ||
|
|
||
| import ( | ||
| "fmt" | ||
| "time" | ||
| ) | ||
|
|
||
| const ( | ||
| DefaultMaxFileSizeBytes uint64 = 104857600 | ||
| MaxFileNameLength int = 255 | ||
| ) | ||
|
|
||
| type AttachmentStatus string | ||
|
|
||
| const ( | ||
| StatusPending AttachmentStatus = "pending" | ||
| StatusUploaded AttachmentStatus = "uploaded" | ||
| ) | ||
|
|
||
| type Attachment struct { | ||
| ID int64 | ||
| TaskID int64 | ||
| FileName string | ||
| StorageKey string | ||
| SizeBytes uint64 | ||
| Status AttachmentStatus | ||
| UploadedBy int64 | ||
| UploadedAt time.Time | ||
| DeletedAt *time.Time | ||
| } | ||
|
|
||
| type AttachmentInput struct { | ||
| TaskID int64 | ||
| FileName string | ||
| SizeBytes uint64 | ||
| UploaderID int64 | ||
| } | ||
|
|
||
| type UploadResult struct { | ||
| Attachment *Attachment | ||
| UploadURL string | ||
| } | ||
|
|
||
| type AttachmentWithURL struct { | ||
| Attachment | ||
|
|
||
| DownloadURL string | ||
| } | ||
|
|
||
| func (i AttachmentInput) Validate(maxFileSize uint64) error { | ||
| if i.TaskID <= 0 { | ||
| return fmt.Errorf("%w: task_id must be positive", ErrValidationFailed) | ||
| } | ||
|
|
||
| if i.UploaderID <= 0 { | ||
| return fmt.Errorf("%w: uploader_id must be positive", ErrValidationFailed) | ||
| } | ||
|
|
||
| fileName := sanitizeFileName(i.FileName) | ||
| if fileName == "" { | ||
| return fmt.Errorf("%w: file_name is required", ErrValidationFailed) | ||
| } | ||
|
|
||
| if len(fileName) > MaxFileNameLength { | ||
| return fmt.Errorf("%w: file_name too long (max %d characters)", ErrValidationFailed, MaxFileNameLength) | ||
| } | ||
|
|
||
| if i.SizeBytes == 0 { | ||
| return fmt.Errorf("%w: size_bytes must be positive", ErrValidationFailed) | ||
| } | ||
|
|
||
| if i.SizeBytes > maxFileSize { | ||
| return ErrFileTooLarge | ||
| } | ||
|
|
||
| return nil | ||
| } | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.