From 169834bfd49d25e173aaf2040ea57eb1aabb473f Mon Sep 17 00:00:00 2001 From: bosch Date: Thu, 3 Dec 2020 13:51:09 +0800 Subject: [PATCH 01/20] Added icon policy documentation --- doc/icon_policy.md | 59 ++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 59 insertions(+) create mode 100644 doc/icon_policy.md diff --git a/doc/icon_policy.md b/doc/icon_policy.md new file mode 100644 index 00000000000..16570892e69 --- /dev/null +++ b/doc/icon_policy.md @@ -0,0 +1,59 @@ +# Icon policy +This document provides guidelines for contributing icons to Bitcoin Core. + + + +## Preparing Icons +Both an icon source file, in Scalable Vector Graphics (SVG) format, and an optimised production file, in Portable Network Graphics (PNG) format, are required for +each icon. + +SVGs are used as source files due to being able to scale to any size whilst retaining image quality, but are not used in production due to limited support by +applications. If different sized production (PNG) icons are required they can be generated from the associated scaled SVG source file in a vector based tool like +Inkspace, Adobe illustrator, Figma, Sketch or Adobe XD. + +PNGs are used in production due to their wide support in applications, support of transparent backgrounds and better image quality than competing file types +such as JPEG. + + +### Icon Grid +Bitcoin Core uses an 8-point grid system for its icons which utilises size increments of 8px to visually orientate elements within a grid. Majority of screen sizes are divisible by 8 which makes fitting elements easier using an 8-point grid system. This makes things more efficient for designers and maintains consistency across applications. + + +### Icon Style +Icon style should follow a few basic principles to maintain consistency and clarity: + +- Icons should be minimal with little to no fine details. This is to make sure icons look good at any scale. +- Icons size should be 32x32px. Different sized icons sizes may be necessary in some circumstances. If 32x32px is too small for the required icon placement, then the icon should be scaled up or down whilst sticking to the 8-point grid system. +- Shapes should be consistent and avoid organic elements that do not scale well. +- Colors should be consistent with other icons used in Bitcoin Core. +- Icons should should follow an 8-point grid system (see above). + + +### Optimizing Production Files (PNG): +Production (PNG) files are to be optmized before being added to Bitcoin Core. Optimizing PNG files removes various color profiles, ancillary (alla) and text chunks resulting in a reduction in size of the image file losslessly (without a lowered image quality). Any `zopflipng` / `pngcrush` based PNG optimizers can be used, below are some examples: + +- Open source tool [ImageOptim](https://imageoptim.com/api). +- Open source tool [Trimage](https://trimage.org/). +- (Advanced) Run them through Bitcoin Cores [optimize-png.py](https://github.com/bitcoin-core/bitcoin-maintainer-tools/blob/master/optimise-pngs.py) script. + + + +## Contributing +Icons should only be added to the Bitcoin Core repo via a pull request (PR) in two situations: + +- An icon used in production is being replaced with a new icon. +- A feature is being added to the Bitcoin Core GUI that requires the addition of a new icon. + +If a new icon is designed for an upcoming or active PR, the designer of the icon should [open an issue](https://github.com/bitcoin-core/gui/issues/new/choose) to get feedback on the design and to make sure it is consistent with Bitcoin Core's iconography. + +If a new feature is being added to the Bitcoin Core GUI that requires a new icon the developer should [open an issue](https://github.com/bitcoin-core/gui/issues/new/choose) requesting an icon to be designed. + +Icons (both SVG and PNG) should not be added to the Bitcoin Core repo if they are not yet used in production. + +When opening a PR that adds an icon source (SVG) files should be added to `src/qt/res/src` at 32x32px and optimized production (PNG) files should be added to `src/qt/res/icons` at 32x32px. + + + +## Attribution +Icon additions should have the appropriate attribution to the author, the licence used for the icon and any comments relevant to the icon included in the +[contrib/debian/copyright](https://github.com/bitcoin-core/gui/blob/master/contrib/debian/copyright) file. From 78b214f8f5b273d3ff583b4d154c0e10a5f82dcc Mon Sep 17 00:00:00 2001 From: bosch <55287964+Bosch-0@users.noreply.github.com> Date: Fri, 4 Dec 2020 17:30:35 +0800 Subject: [PATCH 02/20] Update doc/icon_policy.md Changed optimized spelling to optimised. Co-authored-by: Jarol Rodriguez --- doc/icon_policy.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/icon_policy.md b/doc/icon_policy.md index 16570892e69..be1d679c355 100644 --- a/doc/icon_policy.md +++ b/doc/icon_policy.md @@ -4,7 +4,7 @@ This document provides guidelines for contributing icons to Bitcoin Core. ## Preparing Icons -Both an icon source file, in Scalable Vector Graphics (SVG) format, and an optimised production file, in Portable Network Graphics (PNG) format, are required for +Both an icon source file, in Scalable Vector Graphics (SVG) format, and an optimized production file, in Portable Network Graphics (PNG) format, are required for each icon. SVGs are used as source files due to being able to scale to any size whilst retaining image quality, but are not used in production due to limited support by From a265672b22d9eae16e3303b37140fb3f0ccd74a5 Mon Sep 17 00:00:00 2001 From: bosch <55287964+Bosch-0@users.noreply.github.com> Date: Fri, 4 Dec 2020 17:31:11 +0800 Subject: [PATCH 03/20] Update doc/icon_policy.md Co-authored-by: Jarol Rodriguez --- doc/icon_policy.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/icon_policy.md b/doc/icon_policy.md index be1d679c355..d0be76b99f6 100644 --- a/doc/icon_policy.md +++ b/doc/icon_policy.md @@ -9,7 +9,7 @@ each icon. SVGs are used as source files due to being able to scale to any size whilst retaining image quality, but are not used in production due to limited support by applications. If different sized production (PNG) icons are required they can be generated from the associated scaled SVG source file in a vector based tool like -Inkspace, Adobe illustrator, Figma, Sketch or Adobe XD. +Inkspace, Adobe Illustrator, Figma, Sketch, or Adobe XD. PNGs are used in production due to their wide support in applications, support of transparent backgrounds and better image quality than competing file types such as JPEG. From 8020defb3f3ca5fcaba18a5cda5296339f3980b5 Mon Sep 17 00:00:00 2001 From: bosch <55287964+Bosch-0@users.noreply.github.com> Date: Fri, 4 Dec 2020 17:31:41 +0800 Subject: [PATCH 04/20] Update doc/icon_policy.md Co-authored-by: Jarol Rodriguez --- doc/icon_policy.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/icon_policy.md b/doc/icon_policy.md index d0be76b99f6..8c1888bd790 100644 --- a/doc/icon_policy.md +++ b/doc/icon_policy.md @@ -55,5 +55,5 @@ When opening a PR that adds an icon source (SVG) files should be added to `src/q ## Attribution -Icon additions should have the appropriate attribution to the author, the licence used for the icon and any comments relevant to the icon included in the +Icon additions must include appropriate attribution to the author, license information, and any comments relevant to the icon documented under the [contrib/debian/copyright](https://github.com/bitcoin-core/gui/blob/master/contrib/debian/copyright) file. From 05a2b96b7afc8b2259251ffec5617080b32fd462 Mon Sep 17 00:00:00 2001 From: bosch <55287964+Bosch-0@users.noreply.github.com> Date: Fri, 4 Dec 2020 17:33:49 +0800 Subject: [PATCH 05/20] Update doc/icon_policy.md Co-authored-by: Jarol Rodriguez --- doc/icon_policy.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/icon_policy.md b/doc/icon_policy.md index 8c1888bd790..505b1d2ffdc 100644 --- a/doc/icon_policy.md +++ b/doc/icon_policy.md @@ -8,7 +8,7 @@ Both an icon source file, in Scalable Vector Graphics (SVG) format, and an optim each icon. SVGs are used as source files due to being able to scale to any size whilst retaining image quality, but are not used in production due to limited support by -applications. If different sized production (PNG) icons are required they can be generated from the associated scaled SVG source file in a vector based tool like +In the event that different-sized production (PNG) icons are required, they can be generated from the associated SVG source file in a vector-based tool such as: Inkspace, Adobe Illustrator, Figma, Sketch, or Adobe XD. PNGs are used in production due to their wide support in applications, support of transparent backgrounds and better image quality than competing file types From 7fd32ec14eb492447191308d1633050d0ea644e5 Mon Sep 17 00:00:00 2001 From: bosch <55287964+Bosch-0@users.noreply.github.com> Date: Fri, 4 Dec 2020 17:34:05 +0800 Subject: [PATCH 06/20] Update doc/icon_policy.md Co-authored-by: Jarol Rodriguez --- doc/icon_policy.md | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/doc/icon_policy.md b/doc/icon_policy.md index 505b1d2ffdc..e1245557699 100644 --- a/doc/icon_policy.md +++ b/doc/icon_policy.md @@ -7,7 +7,8 @@ This document provides guidelines for contributing icons to Bitcoin Core. Both an icon source file, in Scalable Vector Graphics (SVG) format, and an optimized production file, in Portable Network Graphics (PNG) format, are required for each icon. -SVGs are used as source files due to being able to scale to any size whilst retaining image quality, but are not used in production due to limited support by +#### SVG Source File +SVGs are used as source files because they can scale while retaining image quality, but are not used in production due to limited application support. In the event that different-sized production (PNG) icons are required, they can be generated from the associated SVG source file in a vector-based tool such as: Inkspace, Adobe Illustrator, Figma, Sketch, or Adobe XD. From b0785b3e5881e08f3eb853923783f8d89ca6bc09 Mon Sep 17 00:00:00 2001 From: bosch <55287964+Bosch-0@users.noreply.github.com> Date: Fri, 4 Dec 2020 17:34:13 +0800 Subject: [PATCH 07/20] Update doc/icon_policy.md Co-authored-by: Jarol Rodriguez --- doc/icon_policy.md | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/doc/icon_policy.md b/doc/icon_policy.md index e1245557699..49af648759c 100644 --- a/doc/icon_policy.md +++ b/doc/icon_policy.md @@ -12,7 +12,8 @@ SVGs are used as source files because they can scale while retaining image quali In the event that different-sized production (PNG) icons are required, they can be generated from the associated SVG source file in a vector-based tool such as: Inkspace, Adobe Illustrator, Figma, Sketch, or Adobe XD. -PNGs are used in production due to their wide support in applications, support of transparent backgrounds and better image quality than competing file types +#### PNG Production File +PNGs are used in production due to wide application support, transparency support, and better image quality in comparison to competing file types such as JPEG. From 084d491d91a55c62607ade6b6948669a1b484f8b Mon Sep 17 00:00:00 2001 From: bosch <55287964+Bosch-0@users.noreply.github.com> Date: Fri, 4 Dec 2020 17:34:30 +0800 Subject: [PATCH 08/20] Update doc/icon_policy.md Co-authored-by: Jarol Rodriguez --- doc/icon_policy.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/icon_policy.md b/doc/icon_policy.md index 49af648759c..934971c902b 100644 --- a/doc/icon_policy.md +++ b/doc/icon_policy.md @@ -18,7 +18,7 @@ such as JPEG. ### Icon Grid -Bitcoin Core uses an 8-point grid system for its icons which utilises size increments of 8px to visually orientate elements within a grid. Majority of screen sizes are divisible by 8 which makes fitting elements easier using an 8-point grid system. This makes things more efficient for designers and maintains consistency across applications. +Bitcoin Core uses an 8-point grid system for its icons which utilizes size increments of 8px to visually orientate elements within a grid. The majority of screen sizes are divisible by 8 which makes fitting elements easier using an 8-point grid system. This makes things more efficient for designers and maintains consistency across applications. ### Icon Style From fa344b3ffff85914041575fa3740f76865e0ff34 Mon Sep 17 00:00:00 2001 From: bosch <55287964+Bosch-0@users.noreply.github.com> Date: Fri, 4 Dec 2020 17:34:43 +0800 Subject: [PATCH 09/20] Update doc/icon_policy.md Co-authored-by: Jarol Rodriguez --- doc/icon_policy.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/icon_policy.md b/doc/icon_policy.md index 934971c902b..3b1038d0f66 100644 --- a/doc/icon_policy.md +++ b/doc/icon_policy.md @@ -22,7 +22,7 @@ Bitcoin Core uses an 8-point grid system for its icons which utilizes size incre ### Icon Style -Icon style should follow a few basic principles to maintain consistency and clarity: +Icon style should adhere to the following principles to maintain consistency and clarity: - Icons should be minimal with little to no fine details. This is to make sure icons look good at any scale. - Icons size should be 32x32px. Different sized icons sizes may be necessary in some circumstances. If 32x32px is too small for the required icon placement, then the icon should be scaled up or down whilst sticking to the 8-point grid system. From 1e902cbdce22939b48cd385155d3eed4e36e31fa Mon Sep 17 00:00:00 2001 From: bosch <55287964+Bosch-0@users.noreply.github.com> Date: Fri, 4 Dec 2020 17:34:54 +0800 Subject: [PATCH 10/20] Update doc/icon_policy.md Co-authored-by: Jarol Rodriguez --- doc/icon_policy.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/icon_policy.md b/doc/icon_policy.md index 3b1038d0f66..14ea3e2fa52 100644 --- a/doc/icon_policy.md +++ b/doc/icon_policy.md @@ -24,7 +24,7 @@ Bitcoin Core uses an 8-point grid system for its icons which utilizes size incre ### Icon Style Icon style should adhere to the following principles to maintain consistency and clarity: -- Icons should be minimal with little to no fine details. This is to make sure icons look good at any scale. +- To ensure icons look good at any scale, a minimalistic design should be used. - Icons size should be 32x32px. Different sized icons sizes may be necessary in some circumstances. If 32x32px is too small for the required icon placement, then the icon should be scaled up or down whilst sticking to the 8-point grid system. - Shapes should be consistent and avoid organic elements that do not scale well. - Colors should be consistent with other icons used in Bitcoin Core. From 42a3535d5054bc78be835f5921d823f231080202 Mon Sep 17 00:00:00 2001 From: bosch <55287964+Bosch-0@users.noreply.github.com> Date: Fri, 4 Dec 2020 17:35:25 +0800 Subject: [PATCH 11/20] Update doc/icon_policy.md Co-authored-by: Jarol Rodriguez --- doc/icon_policy.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/icon_policy.md b/doc/icon_policy.md index 14ea3e2fa52..acc52efcc40 100644 --- a/doc/icon_policy.md +++ b/doc/icon_policy.md @@ -25,7 +25,7 @@ Bitcoin Core uses an 8-point grid system for its icons which utilizes size incre Icon style should adhere to the following principles to maintain consistency and clarity: - To ensure icons look good at any scale, a minimalistic design should be used. -- Icons size should be 32x32px. Different sized icons sizes may be necessary in some circumstances. If 32x32px is too small for the required icon placement, then the icon should be scaled up or down whilst sticking to the 8-point grid system. +- Icon size should be 32x32px by default. A different sized icon may be necessary under special circumstances. In the event that the 32x32px size is too small for the required icon placement, then the icon should be scaled up or down while adhering to the 8-point grid system. - Shapes should be consistent and avoid organic elements that do not scale well. - Colors should be consistent with other icons used in Bitcoin Core. - Icons should should follow an 8-point grid system (see above). From a21759b3648d5a460cf187747f22a904d2d8a852 Mon Sep 17 00:00:00 2001 From: bosch <55287964+Bosch-0@users.noreply.github.com> Date: Fri, 4 Dec 2020 17:35:44 +0800 Subject: [PATCH 12/20] Update doc/icon_policy.md Co-authored-by: Jarol Rodriguez --- doc/icon_policy.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/icon_policy.md b/doc/icon_policy.md index acc52efcc40..3d7c16f24b9 100644 --- a/doc/icon_policy.md +++ b/doc/icon_policy.md @@ -26,7 +26,7 @@ Icon style should adhere to the following principles to maintain consistency and - To ensure icons look good at any scale, a minimalistic design should be used. - Icon size should be 32x32px by default. A different sized icon may be necessary under special circumstances. In the event that the 32x32px size is too small for the required icon placement, then the icon should be scaled up or down while adhering to the 8-point grid system. -- Shapes should be consistent and avoid organic elements that do not scale well. +- Icon should avoid organic shapes or elements, these do not scale well. - Colors should be consistent with other icons used in Bitcoin Core. - Icons should should follow an 8-point grid system (see above). From 303468d0b04f303dca57b1f540069a566e81d4cc Mon Sep 17 00:00:00 2001 From: bosch <55287964+Bosch-0@users.noreply.github.com> Date: Fri, 4 Dec 2020 17:35:55 +0800 Subject: [PATCH 13/20] Update doc/icon_policy.md Co-authored-by: Jarol Rodriguez --- doc/icon_policy.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/icon_policy.md b/doc/icon_policy.md index 3d7c16f24b9..6680254e2da 100644 --- a/doc/icon_policy.md +++ b/doc/icon_policy.md @@ -27,7 +27,7 @@ Icon style should adhere to the following principles to maintain consistency and - To ensure icons look good at any scale, a minimalistic design should be used. - Icon size should be 32x32px by default. A different sized icon may be necessary under special circumstances. In the event that the 32x32px size is too small for the required icon placement, then the icon should be scaled up or down while adhering to the 8-point grid system. - Icon should avoid organic shapes or elements, these do not scale well. -- Colors should be consistent with other icons used in Bitcoin Core. +- Colors should be consistent with existing Bitcoin Core icons. - Icons should should follow an 8-point grid system (see above). From ed222fa794c36b8e0127c43baeae5aca2f91d1f1 Mon Sep 17 00:00:00 2001 From: bosch <55287964+Bosch-0@users.noreply.github.com> Date: Fri, 4 Dec 2020 17:36:42 +0800 Subject: [PATCH 14/20] Update doc/icon_policy.md Co-authored-by: Jarol Rodriguez --- doc/icon_policy.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/icon_policy.md b/doc/icon_policy.md index 6680254e2da..fb6844c0052 100644 --- a/doc/icon_policy.md +++ b/doc/icon_policy.md @@ -28,7 +28,7 @@ Icon style should adhere to the following principles to maintain consistency and - Icon size should be 32x32px by default. A different sized icon may be necessary under special circumstances. In the event that the 32x32px size is too small for the required icon placement, then the icon should be scaled up or down while adhering to the 8-point grid system. - Icon should avoid organic shapes or elements, these do not scale well. - Colors should be consistent with existing Bitcoin Core icons. -- Icons should should follow an 8-point grid system (see above). +- Icons should adhere to the 8-point grid system (see above). ### Optimizing Production Files (PNG): From 77e8d1b6eaa8d6ed7264d0eb112ee276277aaee6 Mon Sep 17 00:00:00 2001 From: bosch <55287964+Bosch-0@users.noreply.github.com> Date: Fri, 4 Dec 2020 17:39:08 +0800 Subject: [PATCH 15/20] Update doc/icon_policy.md Co-authored-by: Jarol Rodriguez --- doc/icon_policy.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/icon_policy.md b/doc/icon_policy.md index fb6844c0052..385234dc0f4 100644 --- a/doc/icon_policy.md +++ b/doc/icon_policy.md @@ -52,7 +52,7 @@ If a new feature is being added to the Bitcoin Core GUI that requires a new icon Icons (both SVG and PNG) should not be added to the Bitcoin Core repo if they are not yet used in production. -When opening a PR that adds an icon source (SVG) files should be added to `src/qt/res/src` at 32x32px and optimized production (PNG) files should be added to `src/qt/res/icons` at 32x32px. +When opening a PR that intends to add an icon, a SVG source file must be included under `src/qt/res/src`, and a optimized production file (PNG) must be included under `src/qt/res/icons`. Both source and production files should be 32x32px in size. From da50884d451c79813906dc63836ed6059c4082fc Mon Sep 17 00:00:00 2001 From: bosch <55287964+Bosch-0@users.noreply.github.com> Date: Fri, 4 Dec 2020 17:39:28 +0800 Subject: [PATCH 16/20] Update doc/icon_policy.md Co-authored-by: Jarol Rodriguez --- doc/icon_policy.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/icon_policy.md b/doc/icon_policy.md index 385234dc0f4..3bd1510c5bb 100644 --- a/doc/icon_policy.md +++ b/doc/icon_policy.md @@ -50,7 +50,7 @@ If a new icon is designed for an upcoming or active PR, the designer of the icon If a new feature is being added to the Bitcoin Core GUI that requires a new icon the developer should [open an issue](https://github.com/bitcoin-core/gui/issues/new/choose) requesting an icon to be designed. -Icons (both SVG and PNG) should not be added to the Bitcoin Core repo if they are not yet used in production. +Icons, both SVG and PNG, are not to be added to Bitcoin Core prior to a production use case. When opening a PR that intends to add an icon, a SVG source file must be included under `src/qt/res/src`, and a optimized production file (PNG) must be included under `src/qt/res/icons`. Both source and production files should be 32x32px in size. From 30b4b94894a431860d909e3047c32736c32a5b48 Mon Sep 17 00:00:00 2001 From: bosch <55287964+Bosch-0@users.noreply.github.com> Date: Fri, 4 Dec 2020 17:40:01 +0800 Subject: [PATCH 17/20] Update doc/icon_policy.md Co-authored-by: Jarol Rodriguez --- doc/icon_policy.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/icon_policy.md b/doc/icon_policy.md index 3bd1510c5bb..369fe2e3c27 100644 --- a/doc/icon_policy.md +++ b/doc/icon_policy.md @@ -32,7 +32,7 @@ Icon style should adhere to the following principles to maintain consistency and ### Optimizing Production Files (PNG): -Production (PNG) files are to be optmized before being added to Bitcoin Core. Optimizing PNG files removes various color profiles, ancillary (alla) and text chunks resulting in a reduction in size of the image file losslessly (without a lowered image quality). Any `zopflipng` / `pngcrush` based PNG optimizers can be used, below are some examples: +Production (PNG) files must be optimized before their inclusion in Bitcoin Core. PNG optimization removes various unnecessary color profiles, ancillary (alla), and text chunks resulting in a lossless reduction of the file's size. Any `zopflipng` / `pngcrush` based PNG optimizer can be used. Below are some examples: - Open source tool [ImageOptim](https://imageoptim.com/api). - Open source tool [Trimage](https://trimage.org/). From 773e824a9b67606f2f487d1263c485c807d2d3b0 Mon Sep 17 00:00:00 2001 From: bosch <55287964+Bosch-0@users.noreply.github.com> Date: Fri, 4 Dec 2020 17:40:15 +0800 Subject: [PATCH 18/20] Update doc/icon_policy.md Co-authored-by: Jarol Rodriguez --- doc/icon_policy.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/icon_policy.md b/doc/icon_policy.md index 369fe2e3c27..e18418cd89f 100644 --- a/doc/icon_policy.md +++ b/doc/icon_policy.md @@ -36,7 +36,7 @@ Production (PNG) files must be optimized before their inclusion in Bitcoin Core. - Open source tool [ImageOptim](https://imageoptim.com/api). - Open source tool [Trimage](https://trimage.org/). -- (Advanced) Run them through Bitcoin Cores [optimize-png.py](https://github.com/bitcoin-core/bitcoin-maintainer-tools/blob/master/optimise-pngs.py) script. +- (Advanced) Run them through Bitcoin Core's [optimize-png.py](https://github.com/bitcoin-core/bitcoin-maintainer-tools/blob/master/optimise-pngs.py) script. From 62c93c34c1d9b83cd168b6b1e30d10e01db53e38 Mon Sep 17 00:00:00 2001 From: bosch <55287964+Bosch-0@users.noreply.github.com> Date: Fri, 4 Dec 2020 17:40:29 +0800 Subject: [PATCH 19/20] Update doc/icon_policy.md Co-authored-by: Jarol Rodriguez --- doc/icon_policy.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/icon_policy.md b/doc/icon_policy.md index e18418cd89f..901ff075673 100644 --- a/doc/icon_policy.md +++ b/doc/icon_policy.md @@ -41,7 +41,7 @@ Production (PNG) files must be optimized before their inclusion in Bitcoin Core. ## Contributing -Icons should only be added to the Bitcoin Core repo via a pull request (PR) in two situations: +Icons are to be added to Bitcoin Core, via a pull request (PR), under these circumstances: - An icon used in production is being replaced with a new icon. - A feature is being added to the Bitcoin Core GUI that requires the addition of a new icon. From a609ff5e776de7cd80f9bb9f94751fe70523881d Mon Sep 17 00:00:00 2001 From: bosch <55287964+Bosch-0@users.noreply.github.com> Date: Fri, 4 Dec 2020 17:40:46 +0800 Subject: [PATCH 20/20] Update doc/icon_policy.md Co-authored-by: Jarol Rodriguez --- doc/icon_policy.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/icon_policy.md b/doc/icon_policy.md index 901ff075673..74293a548f1 100644 --- a/doc/icon_policy.md +++ b/doc/icon_policy.md @@ -48,7 +48,7 @@ Icons are to be added to Bitcoin Core, via a pull request (PR), under these circ If a new icon is designed for an upcoming or active PR, the designer of the icon should [open an issue](https://github.com/bitcoin-core/gui/issues/new/choose) to get feedback on the design and to make sure it is consistent with Bitcoin Core's iconography. -If a new feature is being added to the Bitcoin Core GUI that requires a new icon the developer should [open an issue](https://github.com/bitcoin-core/gui/issues/new/choose) requesting an icon to be designed. +If a new feature which requires a new icon is being added to the Bitcoin Core GUI, the developer should [open an issue](https://github.com/bitcoin-core/gui/issues/new/choose) requesting the new icon be designed. Icons, both SVG and PNG, are not to be added to Bitcoin Core prior to a production use case.