From e386cfad5230a2de12bbec496b1a41e1d5fbd6c9 Mon Sep 17 00:00:00 2001 From: Russell Yanofsky Date: Mon, 25 Oct 2021 13:23:25 -0400 Subject: [PATCH] Fix std::move compiler warning MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit include/mp/proxy-io.h: In member function ‘mp::Logger mp::EventLoop::log()’: include/mp/proxy-io.h:160:25: error: moving a local object in a return statement prevents copy elision [-Werror=pessimizing-move] 160 | return std::move(logger); | ~~~~~~~~~^~~~~~~~ include/mp/proxy-io.h:160:25: note: remove ‘std::move’ call --- include/mp/proxy-io.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/mp/proxy-io.h b/include/mp/proxy-io.h index 4bcacfee..e26accb5 100644 --- a/include/mp/proxy-io.h +++ b/include/mp/proxy-io.h @@ -157,7 +157,7 @@ class EventLoop { Logger logger(false, m_log_fn); logger << "{" << LongThreadName(m_exe_name) << "} "; - return std::move(logger); + return logger; } Logger logPlain() { return Logger(false, m_log_fn); } Logger raise() { return Logger(true, m_log_fn); }