diff --git a/bitrepository-alarm-service/src/main/java/org/bitrepository/alarm/alarmservice/WebAlarm.java b/bitrepository-alarm-service/src/main/java/org/bitrepository/alarm/alarmservice/WebAlarm.java index ee8cc7a82..a05494f2c 100644 --- a/bitrepository-alarm-service/src/main/java/org/bitrepository/alarm/alarmservice/WebAlarm.java +++ b/bitrepository-alarm-service/src/main/java/org/bitrepository/alarm/alarmservice/WebAlarm.java @@ -39,16 +39,15 @@ public class WebAlarm { private String alarmRaiser; private String alarmText; private String collectionID; - - public WebAlarm() {} + private String fileID; public WebAlarm(Alarm alarm) { collectionID = alarm.getCollectionID() == null ? "" : alarm.getCollectionID(); + fileID = alarm.getFileID() == null ? "" : alarm.getFileID(); origDateTime = TimeUtils.shortDate(CalendarUtils.convertFromXMLGregorianCalendar(alarm.getOrigDateTime())); alarmRaiser = alarm.getAlarmRaiser(); alarmCode = alarm.getAlarmCode(); alarmText = alarm.getAlarmText(); - } @XmlElement(name = "origDateTime") @@ -95,4 +94,13 @@ public String getCollectionID() { public void setCollectionID(String collectionID) { this.collectionID = collectionID; } + + @XmlElement(name = "fileID") + public String getFileID() { + return fileID; + } + + public void setFileID(String fileID) { + this.fileID = fileID; + } } \ No newline at end of file diff --git a/bitrepository-alarm-service/src/test/java/org/bitrepository/alarm/store/AlarmDatabaseTest.java b/bitrepository-alarm-service/src/test/java/org/bitrepository/alarm/store/AlarmDatabaseTest.java index a6d620149..bdcbc0417 100644 --- a/bitrepository-alarm-service/src/test/java/org/bitrepository/alarm/store/AlarmDatabaseTest.java +++ b/bitrepository-alarm-service/src/test/java/org/bitrepository/alarm/store/AlarmDatabaseTest.java @@ -65,7 +65,7 @@ public class AlarmDatabaseTest extends ExtendedTestCase { File dbDir = null; @BeforeClass (alwaysRun = true) - public void setup() throws Exception { + public void setup() { settings = TestSettingsProvider.reloadSettings("AlarmDatabaseUnderTest"); DerbyDatabaseDestroyer.deleteDatabase( @@ -76,15 +76,15 @@ public void setup() throws Exception { } @AfterMethod (alwaysRun = true) - public void cleanupDatabase() throws Exception { + public void cleanupDatabase() { // TODO DBConnector connector = new DBConnector(settings.getReferenceSettings().getAlarmServiceSettings().getAlarmServiceDatabase()); - DatabaseUtils.executeStatement(connector, "DELETE FROM " + ALARM_TABLE, new Object[0]); - DatabaseUtils.executeStatement(connector, "DELETE FROM " + COMPONENT_TABLE, new Object[0]); + DatabaseUtils.executeStatement(connector, "DELETE FROM " + ALARM_TABLE); + DatabaseUtils.executeStatement(connector, "DELETE FROM " + COMPONENT_TABLE); } @AfterClass (alwaysRun = true) - public void shutdown() throws Exception { + public void shutdown() { addStep("Cleanup after test.", "Should remove directory with test material."); if(dbDir != null) { FileUtils.delete(dbDir); @@ -92,13 +92,13 @@ public void shutdown() throws Exception { } @Test(groups = {"regressiontest", "databasetest"}) - public void AlarmDatabaseExtractionTest() throws Exception { + public void AlarmDatabaseExtractionTest() { addDescription("Testing the connection to the alarm service database especially with regards to " + "extracting the data from it."); addStep("Setup the variables and constants.", "Should be ok."); Date restrictionDate = new Date(123456789); // Sometime between epoch and now! - addStep("Adds the variables to the settings and instantaites the database cache", "Should be connected."); + addStep("Adds the variables to the settings and instantiates the database cache", "Should be connected."); AlarmDAOFactory alarmDAOFactory = new AlarmDAOFactory(); AlarmServiceDAO database = alarmDAOFactory.getAlarmServiceDAOInstance( settings.getReferenceSettings().getAlarmServiceSettings().getAlarmServiceDatabase()); @@ -184,7 +184,7 @@ public void AlarmDatabaseExtractionTest() throws Exception { } @Test(groups = {"regressiontest", "databasetest"}) - public void AlarmDatabaseLargeIngestionTest() throws Exception { + public void AlarmDatabaseLargeIngestionTest() { addDescription("Testing the ingestion of a large texts into the database"); addStep("Setup and create alarm", ""); AlarmDAOFactory alarmDAOFactory = new AlarmDAOFactory(); diff --git a/bitrepository-webclient/src/main/webapp/alarm-service.html b/bitrepository-webclient/src/main/webapp/alarm-service.html index fb4728a5f..0a8b76c87 100644 --- a/bitrepository-webclient/src/main/webapp/alarm-service.html +++ b/bitrepository-webclient/src/main/webapp/alarm-service.html @@ -104,6 +104,7 @@ Date Component Collection + FileID Alarm code Description @@ -122,9 +123,8 @@