From 4e9ffa0c46812f5c04f12ad53a55be538088c22a Mon Sep 17 00:00:00 2001 From: RBKR Date: Tue, 11 Mar 2025 16:55:32 +0100 Subject: [PATCH 1/2] Fix workflow interval only being interpreted as 'Never' if value is -1 --- .../integrityservice/web/RestIntegrityService.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/bitrepository-integrity-service/src/main/java/org/bitrepository/integrityservice/web/RestIntegrityService.java b/bitrepository-integrity-service/src/main/java/org/bitrepository/integrityservice/web/RestIntegrityService.java index db411deec..44435d805 100644 --- a/bitrepository-integrity-service/src/main/java/org/bitrepository/integrityservice/web/RestIntegrityService.java +++ b/bitrepository-integrity-service/src/main/java/org/bitrepository/integrityservice/web/RestIntegrityService.java @@ -594,7 +594,7 @@ private void writeWorkflowSetupObject(JobID workflowID, JsonGenerator jg) throws } long runInterval = workflowManager.getRunInterval(workflowID); String intervalString; - if (runInterval == -1) { + if (runInterval < 1) { intervalString = "Never"; } else { intervalString = TimeUtils.millisecondsToHuman(runInterval); From 206e5283e8e071c8d8fdd2b14d9cadf52f5b5c01 Mon Sep 17 00:00:00 2001 From: RBKR Date: Thu, 13 Mar 2025 10:01:14 +0100 Subject: [PATCH 2/2] Change '< 1' condition to '<= 0' as suggested in PR comment --- .../integrityservice/web/RestIntegrityService.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/bitrepository-integrity-service/src/main/java/org/bitrepository/integrityservice/web/RestIntegrityService.java b/bitrepository-integrity-service/src/main/java/org/bitrepository/integrityservice/web/RestIntegrityService.java index 44435d805..e8b5f3fe9 100644 --- a/bitrepository-integrity-service/src/main/java/org/bitrepository/integrityservice/web/RestIntegrityService.java +++ b/bitrepository-integrity-service/src/main/java/org/bitrepository/integrityservice/web/RestIntegrityService.java @@ -594,7 +594,7 @@ private void writeWorkflowSetupObject(JobID workflowID, JsonGenerator jg) throws } long runInterval = workflowManager.getRunInterval(workflowID); String intervalString; - if (runInterval < 1) { + if (runInterval <= 0) { intervalString = "Never"; } else { intervalString = TimeUtils.millisecondsToHuman(runInterval);