From 8a13da5178ad6a748b6075f470cb421a7a26324a Mon Sep 17 00:00:00 2001 From: ibaaaaal Date: Wed, 18 Feb 2026 07:14:23 +0700 Subject: [PATCH] fix: prevent SageMaker TGI and Bedrock config detection issues - SageMaker TGI: mark SAGEMAKER_ENDPOINT_NAME as required, AWS_REGION/AWS_PROFILE as optional - Bedrock: mark AWS_REGION as required with default to fix is_configured always returning false Signed-off-by: ibaaaaal rifaldi.51922721@mahasiswa.unikom.ac.id --- crates/goose/src/providers/bedrock.rs | 11 +++++++++-- crates/goose/src/providers/sagemaker_tgi.rs | 6 +++--- 2 files changed, 12 insertions(+), 5 deletions(-) diff --git a/crates/goose/src/providers/bedrock.rs b/crates/goose/src/providers/bedrock.rs index 07f390ee760e..8d91a638b9dd 100644 --- a/crates/goose/src/providers/bedrock.rs +++ b/crates/goose/src/providers/bedrock.rs @@ -278,7 +278,7 @@ impl ProviderDef for BedrockProvider { BEDROCK_DOC_LINK, vec![ ConfigKey::new("AWS_PROFILE", false, false, Some("default")), - ConfigKey::new("AWS_REGION", false, false, None), + ConfigKey::new("AWS_REGION", true, false, Some("us-east-1")), ConfigKey::new("AWS_BEARER_TOKEN_BEDROCK", false, true, None), ], ) @@ -384,11 +384,18 @@ mod tests { .iter() .find(|k| k.name == "AWS_REGION") .expect("AWS_REGION config key should exist"); - assert!(!aws_region.required, "AWS_REGION should not be required"); + assert!( + aws_region.required, + "AWS_REGION is required for Bedrock to be marked as configured" + ); assert!( !aws_region.secret, "AWS_REGION should not be marked as secret" ); + assert!( + aws_region.default.is_some(), + "AWS_REGION should have a default value" + ); let bearer_token = meta .config_keys diff --git a/crates/goose/src/providers/sagemaker_tgi.rs b/crates/goose/src/providers/sagemaker_tgi.rs index 06b0fdc24ef9..949ddbd220b9 100644 --- a/crates/goose/src/providers/sagemaker_tgi.rs +++ b/crates/goose/src/providers/sagemaker_tgi.rs @@ -284,9 +284,9 @@ impl ProviderDef for SageMakerTgiProvider { vec![SAGEMAKER_TGI_DEFAULT_MODEL], SAGEMAKER_TGI_DOC_LINK, vec![ - ConfigKey::new("SAGEMAKER_ENDPOINT_NAME", false, false, None), - ConfigKey::new("AWS_REGION", true, false, Some("us-east-1")), - ConfigKey::new("AWS_PROFILE", true, false, Some("default")), + ConfigKey::new("SAGEMAKER_ENDPOINT_NAME", true, false, None), + ConfigKey::new("AWS_REGION", false, false, Some("us-east-1")), + ConfigKey::new("AWS_PROFILE", false, false, Some("default")), ], ) }