From 6d7f64e6a750b9fa339793cad90d1e5c716048cd Mon Sep 17 00:00:00 2001 From: Dave Lambley Date: Wed, 3 Jun 2020 22:08:59 +0100 Subject: [PATCH 1/4] Use Dist::Zilla::Plugin::OurPkgVersion Kwalitee complains that the non main modules have regressed in version, as they no version number. --- dist.ini | 5 ++++- lib/AnyEvent/RabbitMQ.pm | 2 +- lib/AnyEvent/RabbitMQ/Channel.pm | 2 ++ lib/AnyEvent/RabbitMQ/LocalQueue.pm | 2 ++ 4 files changed, 9 insertions(+), 2 deletions(-) diff --git a/dist.ini b/dist.ini index 5e6d7dc..c2781d8 100644 --- a/dist.ini +++ b/dist.ini @@ -2,6 +2,7 @@ name = AnyEvent-RabbitMQ author = Masahito Ikuta license = Perl_5 copyright_holder = AnyEvent-RabbitMQ's developers +version = 1.21_02 [@Filter] -bundle = @Basic @@ -19,9 +20,11 @@ x_contributors = Julio Polo [InstallGuide] [CPANFile] -[VersionFromModule] [MetaJSON] +[OurPkgVersion] +underscore_eval_version=1 + [MetaResources] repository.url = git://github.com/bobtfish/AnyEvent-RabbitMQ.git repository.web = https://github.com/bobtfish/AnyEvent-RabbitMQ diff --git a/lib/AnyEvent/RabbitMQ.pm b/lib/AnyEvent/RabbitMQ.pm index af88d0c..06fe61a 100644 --- a/lib/AnyEvent/RabbitMQ.pm +++ b/lib/AnyEvent/RabbitMQ.pm @@ -32,7 +32,7 @@ use AnyEvent::RabbitMQ::LocalQueue; use namespace::clean; -our $VERSION = '1.21'; +# VERSION use constant { _ST_CLOSED => 0, diff --git a/lib/AnyEvent/RabbitMQ/Channel.pm b/lib/AnyEvent/RabbitMQ/Channel.pm index 4edd382..ab19ef1 100644 --- a/lib/AnyEvent/RabbitMQ/Channel.pm +++ b/lib/AnyEvent/RabbitMQ/Channel.pm @@ -11,6 +11,8 @@ use Carp qw(croak cluck); use POSIX qw(ceil); BEGIN { *Dumper = \&AnyEvent::RabbitMQ::Dumper } +# VERSION + use namespace::clean; use constant { diff --git a/lib/AnyEvent/RabbitMQ/LocalQueue.pm b/lib/AnyEvent/RabbitMQ/LocalQueue.pm index de5423f..6e222a8 100644 --- a/lib/AnyEvent/RabbitMQ/LocalQueue.pm +++ b/lib/AnyEvent/RabbitMQ/LocalQueue.pm @@ -3,6 +3,8 @@ package AnyEvent::RabbitMQ::LocalQueue; use strict; use warnings; +# VERSION + sub new { my $class = shift; return bless { From cb47a14746772d1d4cf9909f10bd643e44fc8642 Mon Sep 17 00:00:00 2001 From: Dave Lambley Date: Wed, 3 Jun 2020 22:10:14 +0100 Subject: [PATCH 2/4] Bump changelog --- Changes | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Changes b/Changes index 02817c6..09b5406 100644 --- a/Changes +++ b/Changes @@ -1,5 +1,7 @@ Revision history for Perl extension AnyEvent::RabbitMQ + - Assign a version number to all modules in package. + 1.21 Sat 30 May 23:40:54 BST 2020 - No changes. From bbd795bc036cee632b6bfb6c2bc2cbb9a48482bc Mon Sep 17 00:00:00 2001 From: Dave Lambley Date: Wed, 3 Jun 2020 22:31:18 +0100 Subject: [PATCH 3/4] Keep perlcritic happy --- dist.ini | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/dist.ini b/dist.ini index c2781d8..e9b4109 100644 --- a/dist.ini +++ b/dist.ini @@ -23,7 +23,8 @@ x_contributors = Julio Polo [MetaJSON] [OurPkgVersion] -underscore_eval_version=1 +underscore_eval_version = 1 +no_critic = 1 [MetaResources] repository.url = git://github.com/bobtfish/AnyEvent-RabbitMQ.git From d2a6a9a37cb2bb07aa19e8a2b4d816ebac4982e7 Mon Sep 17 00:00:00 2001 From: Dave Lambley Date: Wed, 3 Jun 2020 22:32:29 +0100 Subject: [PATCH 4/4] Don't run tests on authordeps Be consistent with other use of cpanm --- .github/workflows/actions.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/actions.yml b/.github/workflows/actions.yml index 8aeb8c1..32c190c 100644 --- a/.github/workflows/actions.yml +++ b/.github/workflows/actions.yml @@ -81,7 +81,7 @@ jobs: perl-version: ${{ matrix.perl }} - run: perl -V - run: cpanm --quiet --notest Dist::Zilla - - run: dzil authordeps | cpanm --quiet + - run: dzil authordeps | cpanm --quiet -notest - run: dzil build - uses: actions/upload-artifact@v2 with: