Clean up some PHPStan nonsense.

Author: bobthecow

src/functions.php

@@ -395,7 +395,7 @@ function bin(): \Closure
             }
 
             // Handle --help
-            if ($usageException !== null || $input->getOption('help')) {
+            if (!isset($config) || $usageException !== null || $input->getOption('help')) {
                 if ($usageException !== null) {
                     echo $usageException->getMessage().\PHP_EOL.\PHP_EOL;
                 }

test/FakeShell.php

@@ -20,7 +20,8 @@ class FakeShell extends Shell
 
     public function __construct(Configuration $config = null)
     {
-        // This space intentionally left blank
+        // Do something (silly) with $config for phpstan's sake.
+        $config = null;
     }
 
     public function addMatchers(array $matchers)

test/fixtures/config.php

@@ -9,6 +9,10 @@
  * file that was distributed with this source code.
  */
 
+if (!isset($config)) {
+    throw new \Exception('$config not found');
+}
+
 $config->setRuntimeDir(\sys_get_temp_dir().'/psysh_test/withconfig/temp');
 
 return [

vendor-bin/phpstan/baseline.neon

@@ -1,5 +1,9 @@
 parameters:
 	ignoreErrors:
+		-
+			message: '#^Variable \$string on left side of \?\? always exists and is not nullable\.$#'
+			path: ../../src/Readline/Hoa/ConsoleOutput.php
+
 		-
 			message: "#^Variable \\$_except in empty\\(\\) always exists and is always falsy\\.$#"
 			count: 1
@@ -10,6 +14,7 @@ parameters:
 			count: 2
 			path: ../../src/Readline/Hoa/Readline.php
 
+		# PHPStan appears incapable of dealing with constructor parameters required by an interface, so...
 		-
 			message: "#^Constructor of class Psy\\\\Readline\\\\Transient has an unused parameter \\$historyFile\\.$#"
 			count: 1
@@ -29,32 +34,3 @@ parameters:
 			message: "#^Constructor of class Psy\\\\Readline\\\\Userland has an unused parameter \\$historySize\\.$#"
 			count: 1
 			path: ../../src/Readline/Userland.php
-
-		-
-			message: "#^Variable \\$config might not be defined\\.$#"
-			count: 3
-			path: ../../src/functions.php
-
-		-
-			message: "#^Constructor of class Psy\\\\Test\\\\FakeShell has an unused parameter \\$config\\.$#"
-			count: 1
-			path: ../../test/FakeShell.php
-
-		-
-			message: "#^Variable \\$config might not be defined\\.$#"
-			count: 1
-			path: ../../test/fixtures/config.php
-
-		-
-			message: "#^Constructor of class Psy\\\\Command\\\\ShowCommand has an unused parameter \\$colorMode\\.$#"
-			count: 1
-			path: ../../src/Command/ShowCommand.php
-
-		-
-			message: "#^Constructor of class Psy\\\\Command\\\\WhereamiCommand has an unused parameter \\$colorMode\\.$#"
-			count: 1
-			path: ../../src/Command/WhereamiCommand.php
-
-		-
-			message: '#^Variable \$string on left side of \?\? always exists and is not nullable\.$#'
-			path: ../../src/Readline/Hoa/ConsoleOutput.php