From 57f66eded5b1946e91daeca163a975b74f4a0e0e Mon Sep 17 00:00:00 2001 From: Victor Adossi Date: Fri, 11 Jul 2025 01:51:43 +0900 Subject: [PATCH 1/2] chore(ci): add clippy to CI --- .github/workflows/main.yml | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index d3cd5466..a75ee18b 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -27,9 +27,13 @@ jobs: rustup update stable rustup default stable rustup component add rustfmt + - name: Format source code run: cargo fmt -- --check + - name: Run clippy + run: cargo clippy --workspace --all-targets --all-features + ######### # Build # ######### From b6977557d75221efc0c545bfc19530e6a5d81a38 Mon Sep 17 00:00:00 2001 From: Victor Adossi Date: Mon, 14 Jul 2025 22:19:35 +0900 Subject: [PATCH 2/2] refactor: hoist too_many_arguments special clippy ignore --- Cargo.toml | 3 +++ crates/spidermonkey-embedding-splicer/Cargo.toml | 3 +++ crates/splicer-component/Cargo.toml | 3 +++ 3 files changed, 9 insertions(+) diff --git a/Cargo.toml b/Cargo.toml index c569e192..39e8d176 100644 --- a/Cargo.toml +++ b/Cargo.toml @@ -7,6 +7,9 @@ resolver = "2" edition = "2021" version = "0.1.0" +[workspace.lints.clippy] +too_many_arguments = 'allow' + [workspace.dependencies] anyhow = { version = "1.0.95", default-features = false } heck = { version = "0.5", default-features = false } diff --git a/crates/spidermonkey-embedding-splicer/Cargo.toml b/crates/spidermonkey-embedding-splicer/Cargo.toml index 99f9c568..be8d7e6d 100644 --- a/crates/spidermonkey-embedding-splicer/Cargo.toml +++ b/crates/spidermonkey-embedding-splicer/Cargo.toml @@ -8,6 +8,9 @@ edition.workspace = true [lib] +[lints] +workspace = true + [dependencies] anyhow = { workspace = true } clap = { version = "4.5.31", features = ["suggestions", "color", "derive"] } diff --git a/crates/splicer-component/Cargo.toml b/crates/splicer-component/Cargo.toml index b86ed533..33725ebd 100644 --- a/crates/splicer-component/Cargo.toml +++ b/crates/splicer-component/Cargo.toml @@ -7,5 +7,8 @@ version.workspace = true [lib] crate-type = ["cdylib"] +[lints] +workspace = true + [dependencies] spidermonkey-embedding-splicer = { path = "../spidermonkey-embedding-splicer" }